fix: enable more compiler warnings, small fixup of unused parameters

This commit is contained in:
Kilian Bracher 2025-02-25 21:00:54 +01:00
parent 1ddf460dd1
commit 219a5c3a87
Signed by: k.bracher
SSH Key Fingerprint: SHA256:mXpyZkK7RDiJ7qeHCKJX108woM0cl5TrCvNBJASu6lM
5 changed files with 6 additions and 5 deletions

View File

@ -31,7 +31,7 @@ HAL_StatusTypeDef amsCellMeasurement(Cell_Module (*module)[N_BMS]);
HAL_StatusTypeDef amsAuxAndStatusMeasurement(Cell_Module (*module)[N_BMS]);
HAL_StatusTypeDef amsConfigBalancing(const uint32_t channels[static N_BMS], uint8_t dutyCycle);
HAL_StatusTypeDef amsStartBalancing(uint8_t dutyCycle);
HAL_StatusTypeDef amsStartBalancing();
HAL_StatusTypeDef amsStopBalancing();
HAL_StatusTypeDef amsSelfTest();

View File

@ -27,7 +27,7 @@ uint8_t adbmsDriverInit(SPI_HandleTypeDef* hspi);
HAL_StatusTypeDef ___writeCMD(uint16_t command, uint8_t * args, size_t arglen);
[[gnu::access(read_write, 2, 4), gnu::nonnull(2), gnu::always_inline]] //add dummy size variable for bounds checking, should be optimized out
static inline HAL_StatusTypeDef __writeCMD(uint16_t command, uint8_t * args, size_t arglen, size_t _) {
static inline HAL_StatusTypeDef __writeCMD(uint16_t command, uint8_t * args, size_t arglen, size_t) {
return ___writeCMD(command, args, arglen);
}
@ -37,7 +37,7 @@ static inline HAL_StatusTypeDef __writeCMD(uint16_t command, uint8_t * args, siz
HAL_StatusTypeDef ___readCMD(uint16_t command, uint8_t * buffer, size_t arglen);
[[gnu::access(read_write, 2, 4), gnu::nonnull(2), gnu::always_inline]] //add dummy size variable for bounds checking, should be optimized out
static inline HAL_StatusTypeDef __readCMD(uint16_t command, uint8_t * buffer, size_t arglen, size_t _) {
static inline HAL_StatusTypeDef __readCMD(uint16_t command, uint8_t * buffer, size_t arglen, size_t) {
return ___readCMD(command, buffer, arglen);
}

View File

@ -220,7 +220,7 @@ HAL_StatusTypeDef amsConfigBalancing(const uint32_t channels[static N_BMS], uint
return HAL_OK;
}
HAL_StatusTypeDef amsStartBalancing(uint8_t dutyCycle) { return writeCMD(UNMUTE, CMD_EMPTY_BUFFER, 0); }
HAL_StatusTypeDef amsStartBalancing() { return writeCMD(UNMUTE, CMD_EMPTY_BUFFER, 0); }
HAL_StatusTypeDef amsStopBalancing() { return writeCMD(MUTE, CMD_EMPTY_BUFFER, 0); }

View File

@ -42,7 +42,7 @@ ADBMS_DetailedStatus AMS_Init(SPI_HandleTypeDef* hspi) {
numberofCells);
if (initAMS(hspi) != HAL_OK) {
debug_log(LOG_LEVEL_ERROR, "ADBMS6830B HAL - initialization failed");
return (ADBMS_DetailedStatus){ADBMS_INTERNAL_BMS_FAULT};
return (ADBMS_DetailedStatus){ADBMS_INTERNAL_BMS_FAULT, -1};
}
pollingTimes = (struct pollingTimes){HAL_GetTick(), HAL_GetTick()};

View File

@ -39,6 +39,7 @@ asDefinitionsFile:
# Compiler flags
cFlags:
- -Wall
- -Wextra
- -fdata-sections
- -ffunction-sections
- -std=gnu23