diff --git a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_Abstraction.h b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_Abstraction.h index bb29f60..8eb37b9 100644 --- a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_Abstraction.h +++ b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_Abstraction.h @@ -31,7 +31,7 @@ HAL_StatusTypeDef amsCellMeasurement(Cell_Module (*module)[N_BMS]); HAL_StatusTypeDef amsAuxAndStatusMeasurement(Cell_Module (*module)[N_BMS]); HAL_StatusTypeDef amsConfigBalancing(const uint32_t channels[static N_BMS], uint8_t dutyCycle); -HAL_StatusTypeDef amsStartBalancing(uint8_t dutyCycle); +HAL_StatusTypeDef amsStartBalancing(); HAL_StatusTypeDef amsStopBalancing(); HAL_StatusTypeDef amsSelfTest(); diff --git a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_LL_Driver.h b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_LL_Driver.h index 1c4b924..766d944 100644 --- a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_LL_Driver.h +++ b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Inc/ADBMS_LL_Driver.h @@ -27,7 +27,7 @@ uint8_t adbmsDriverInit(SPI_HandleTypeDef* hspi); HAL_StatusTypeDef ___writeCMD(uint16_t command, uint8_t * args, size_t arglen); [[gnu::access(read_write, 2, 4), gnu::nonnull(2), gnu::always_inline]] //add dummy size variable for bounds checking, should be optimized out -static inline HAL_StatusTypeDef __writeCMD(uint16_t command, uint8_t * args, size_t arglen, size_t _) { +static inline HAL_StatusTypeDef __writeCMD(uint16_t command, uint8_t * args, size_t arglen, size_t) { return ___writeCMD(command, args, arglen); } @@ -37,7 +37,7 @@ static inline HAL_StatusTypeDef __writeCMD(uint16_t command, uint8_t * args, siz HAL_StatusTypeDef ___readCMD(uint16_t command, uint8_t * buffer, size_t arglen); [[gnu::access(read_write, 2, 4), gnu::nonnull(2), gnu::always_inline]] //add dummy size variable for bounds checking, should be optimized out -static inline HAL_StatusTypeDef __readCMD(uint16_t command, uint8_t * buffer, size_t arglen, size_t _) { +static inline HAL_StatusTypeDef __readCMD(uint16_t command, uint8_t * buffer, size_t arglen, size_t) { return ___readCMD(command, buffer, arglen); } diff --git a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_Abstraction.c b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_Abstraction.c index 1440728..d0611a0 100644 --- a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_Abstraction.c +++ b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_Abstraction.c @@ -220,7 +220,7 @@ HAL_StatusTypeDef amsConfigBalancing(const uint32_t channels[static N_BMS], uint return HAL_OK; } -HAL_StatusTypeDef amsStartBalancing(uint8_t dutyCycle) { return writeCMD(UNMUTE, CMD_EMPTY_BUFFER, 0); } +HAL_StatusTypeDef amsStartBalancing() { return writeCMD(UNMUTE, CMD_EMPTY_BUFFER, 0); } HAL_StatusTypeDef amsStopBalancing() { return writeCMD(MUTE, CMD_EMPTY_BUFFER, 0); } diff --git a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_HighLevel.c b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_HighLevel.c index fc7ca1d..fc81f66 100644 --- a/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_HighLevel.c +++ b/AMS_Master_Code/Core/Lib/ADBMS6830B_Driver/Core/Src/ADBMS_HighLevel.c @@ -42,7 +42,7 @@ ADBMS_DetailedStatus AMS_Init(SPI_HandleTypeDef* hspi) { numberofCells); if (initAMS(hspi) != HAL_OK) { debug_log(LOG_LEVEL_ERROR, "ADBMS6830B HAL - initialization failed"); - return (ADBMS_DetailedStatus){ADBMS_INTERNAL_BMS_FAULT}; + return (ADBMS_DetailedStatus){ADBMS_INTERNAL_BMS_FAULT, -1}; } pollingTimes = (struct pollingTimes){HAL_GetTick(), HAL_GetTick()}; diff --git a/AMS_Master_Code/STM32-for-VSCode.config.yaml b/AMS_Master_Code/STM32-for-VSCode.config.yaml index 7e7ba5b..0eedae3 100644 --- a/AMS_Master_Code/STM32-for-VSCode.config.yaml +++ b/AMS_Master_Code/STM32-for-VSCode.config.yaml @@ -39,6 +39,7 @@ asDefinitionsFile: # Compiler flags cFlags: - -Wall + - -Wextra - -fdata-sections - -ffunction-sections - -std=gnu23