Edward Hervey
9e2bb037f0
playbin2: Remove dead code
...
blacklisted_mimes has been empty for ages. Remove the code "using" it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2306 >
2022-04-27 13:13:17 +00:00
Mathieu Duponchelle
14b37268f6
timeoverlay: add support for reference timestamp time mode
...
+ update date-time mode to actually use the timestamp that
was selected with the time-mode property
Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2252 >
2022-04-27 12:35:21 +00:00
Sebastian Dröge
9d5179ad3f
rtpjitterbuffer: add the reference timestamp meta in more situations
...
Previously, we only added it when actually performing synchronization
based on the NTP time.
The information can be useful downstream in other situations too, and
we can compute a NTP time as soon as we get a sender report with the
relevant information.
Co-authored-by: Mathieu Duponchelle <mathieu@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2252 >
2022-04-27 12:35:21 +00:00
Sebastian Dröge
ed425e2785
rtpgstpay: Don't push packets before the first input buffer is received
...
It's not possible to create a valid RTP timestamp for them, which would
cause a potentially very big RTP timestamp discontinuity between those
first packets (created from initial events) and the packet based on the
first input buffer.
As a side-effect, also simplify the packet aggregation code a bit and
work with only a single level of buffer lists.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1157
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2250 >
2022-04-27 11:55:17 +00:00
Mathieu Duponchelle
a03db32bbe
rtpbasepayload: always store input buffer meta before negotiation
...
The decision to store the input buffer depends on whether extensions
are to be added to the output buffer, I assume as an optimization.
This creates an issue for subclasses that call negotiate(), where
header_exts is actually populated, from their handle_buffer()
implementation: at chain time, no header extension has been negotiated
yet, which means that we don't add extensions to the first batch of
buffers that comes out.
Keep track of whether negotiate has been called (this is different
from the negotiated field) and always store the input buffer until
then. This fixes the issue while largely preserving the optimization.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2304 >
2022-04-27 08:43:30 +00:00
Mathieu Duponchelle
4cd3830bc8
tests/onvif: improve robustness
...
The previous iteration of the code was inferring the type of the
frame by looking at the overall size of the gst-payloaded packet.
It is more robust to actually parse the payload and look at the
actual data buffers it contains.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2303 >
2022-04-27 06:39:24 +00:00
Mathieu Duponchelle
9689693534
tests/onvif: don't push buffers outside segment
...
segment->stop is exclusive, so in reverse playback mode we do not
need to output a buffer at that position as it will simply get
clipped in basesink.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2303 >
2022-04-27 06:39:24 +00:00
Mathieu Duponchelle
efc29565d6
rtponviftimestamp: add extension data to all packets ..
...
regardless of whether they are input as individual buffers or
buffer lists.
The ONVIF specification requires all packets to hold the extension,
it makes no sense to behave differently when handling buffer lists.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2303 >
2022-04-27 06:39:24 +00:00
Thibault Saunier
3c959ff53e
cudaconvert: Enhance debugging when setting video info fails
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2300 >
2022-04-26 19:04:06 +00:00
He Junyan
9ec4041a51
codecparsers: bitwriter: Calculate PicSizeInCtbsY when writing slice header.
...
The slice->pps->PicWidthInCtbsY/PicHeightInCtbsY values are calculated when
we parse the slice header. But they are not calculated in bitwriter and so
may not have valid value when writing slice header.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2287 >
2022-04-26 16:04:15 +00:00
He Junyan
abf19020a4
codecparsers: bitwriter: Fix some coverity issues of H265 bitwriter.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2287 >
2022-04-26 16:04:15 +00:00
He Junyan
f55b36e6aa
videoscale: Fix the src video info error in transfer_colorimetry_from_input()
...
Pipeline such as:
gst-launch-1.0 -vf videotestsrc ! video/x-raw,format=NV12,colorimetry=\(string\)bt709 \
! videoscale ! video/x-raw,format=I420 ! fakesink
Always trigger a error:
ERROR video-info video-info.c:556:gst_video_info_from_caps: no width property given
Because it is called before the fixate_size(), the src caps' resolution
may be absent or not fixed. That causes that the src video info can not
be created correctly and we can not inherit the colorimetry and chroma-site
from the input caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2289 >
2022-04-26 14:17:50 +00:00
Guillaume Desmottes
c0d7d5c2c8
videorate: fix assertion when pushing last and only buffer without duration
...
Fixing this pipeline:
gst-launch-1.0 filesrc location=sample.png ! pngdec ! videorate ! fakesink
- videorate receives a single buffer with pts = 0, duration = invalid;
- then it receives eos triggering this buffer to be pushed downstream;
- the pushing code was assuming that a duration was set, which is
impossible as we received a single buffer and no output framerate was
set either. So the best we can do is to push the buffer without
duration.
Fix #1177
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2296 >
2022-04-26 13:43:56 +00:00
He Junyan
264e577e7e
va: dec: Use gst_buffer_pool_config_set_va_alignment() to set alignment.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2282 >
2022-04-26 20:26:09 +08:00
He Junyan
163cbd5892
va: pool: Replace all tabs with spaces in header file.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2282 >
2022-04-26 20:26:06 +08:00
He Junyan
fac57fcb8d
va: pool: Delete the GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT.
...
The va pool is used for GPU side surface/image, its alignment should
not be changed arbitrarily by others. So we decide not to expose the
GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT flag anymore.
Instead, user can call gst_buffer_pool_config_set_va_alignment() to
set its surface/image alignment.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2282 >
2022-04-26 20:26:02 +08:00
He Junyan
fd81cb2ad4
va: pool: Add set_va_alignment() API.
...
We want to use gst_buffer_pool_config_set_va_alignment() to replace
gst_buffer_pool_config_get_video_alignment(). The later one is specific
for GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT option.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2282 >
2022-04-26 20:25:57 +08:00
Havard Graff
390ec99f1b
rtptwcc: don't map the buffer twice
...
...and use the pt extracted rather than the one from RTPPacketInfo
when logging.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2271 >
2022-04-26 10:27:25 +00:00
Thibault Saunier
d673a90aea
rtpsession: Emit "notify::stats" when we update stats from RR or SR
...
Sensibily optimizing caching the pspecs and using them directly
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2266 >
2022-04-26 08:49:42 +00:00
Edward Hervey
7b5f867e40
oggdemux: Protect against invalid framerates
...
This check wasn't done for all mappings.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2295 >
2022-04-26 09:29:39 +02:00
He Junyan
b2aaf0f2e5
av1parse: Fix a latent memory leak in colorimetry setting.
...
Also delete the useless "have_cinfo" judgement.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2288 >
2022-04-26 02:14:15 +00:00
He Junyan
164e01b14e
av1parse: Correct the meaning of color_range flag.
...
According to spec:
color range equal to 0 shall be referred to as the studio swing
representation and color range equal to 1 shall be referred to as
the full swing representation.
The current status is just the opposite.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2288 >
2022-04-26 02:14:15 +00:00
Seungha Yang
81ee2a9f2a
qsvencoder: Workaround for invalid DTS with VP9
...
SDK runtime seems to report zero DTS for all frames in case of VP9 but
we don't need to use DTS for the codec.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2291 >
2022-04-26 04:51:54 +09:00
Seungha Yang
205a23f456
nvcodec: Stop building for non-{Windows,Linux} target
...
The other platforms, specifically macOS have not been supported already
because this plugin loads so or dll. Moreover, NVIDIA dropped
support for macOS as of CUDA 11.0. See also
https://developer.nvidia.com/nvidia-cuda-toolkit-11_0_0-developer-tools-mac-hosts
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2283 >
2022-04-25 15:50:52 +00:00
Stéphane Cerveau
12776ba0fd
srtp: add unit tests
...
Enable unit tests in meson.build
Add test_play_key_error to check the stats
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2027 >
2022-04-25 13:57:42 +00:00
Stéphane Cerveau
c77d07752a
srtpdec: add counts in stats
...
In order to count the buffers which have been received and dropped for
decryption reason, add a stats to track it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2027 >
2022-04-25 13:57:42 +00:00
Seungha Yang
9f19ca68b3
d3d11videosink: Fix for unhandled mouse double click events
...
Only window created with CS_DBLCLKS style can receive those mouse
double click events, so we need to use the style for internal/external
windows can get double click events.
Also, passthrough mouse events to parent window in the same message pumping
threads instead of manually forwarding each mouse event.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1172
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2277 >
2022-04-23 13:20:54 +00:00
Mathieu Duponchelle
3391a7d499
rtpredenc: quieten warning about ignoring header extensions
...
Turn it into a FIXME, and only log once
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2279 >
2022-04-23 01:04:54 +00:00
Xavier Claessens
1a0eea3299
Meson: Fix deprecation warnings
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1876 >
2022-04-23 00:33:00 +00:00
Stéphane Cerveau
9d6a7dbdf3
rvsg: fix cairo include
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2276 >
2022-04-23 00:00:23 +00:00
Sebastian Dröge
760b070db9
Revert "videorate: Update the base time on segment updates"
...
This reverts commit 75b4809ebc23814009bebc70c775ab44d85decf2.
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2186
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2254 >
2022-04-22 23:05:57 +00:00
Sebastian Dröge
c39fb85c9b
Revert "videorate: Add test for segment update"
...
This reverts commit a76f38b2c7ddbed546bb058c32ebcf8a553c003f.
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2186
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2254 >
2022-04-22 23:05:57 +00:00
Sebastian Dröge
2599cf573a
Revert "videorate: Only "close" the segment if it is discontinous"
...
This reverts commit 6f7922b4dbba5ed780e7b0988669a81848a9e333.
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2186
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2254 >
2022-04-22 23:05:57 +00:00
Sebastian Dröge
98112a3ddc
Revert "videorate: Drop incoming buffers that are outside of the segment"
...
This reverts commit 24fd80344dbc059b72e13d813ca82f414a9d6cce.
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2186
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2254 >
2022-04-22 23:05:57 +00:00
Sebastian Dröge
a797962d26
Revert "videorate: Add unit test for closing a segment and opening a separate one"
...
This reverts commit 98f2a84a289ed4d4cfac9bc5c73182a56eefa99c.
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2186
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2254 >
2022-04-22 23:05:57 +00:00
Havard Graff
b7b71e6974
rtprtxsend: mark RTX buffers with GST_RTP_BUFFER_FLAG_RETRANSMISSION
...
It is useful for elements downstream from rtxsend to know if the RTP
buffer they are dealing with is an RTX buffer or not.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2272 >
2022-04-22 19:27:45 +00:00
Corentin Damman
df64280874
cuda-converter: fix nvrtc compilation on non-English locale systems
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2268 >
2022-04-22 18:57:22 +00:00
Pierre Bourré
4ac544d5aa
rtspclientsink: fix possible shutdown deadlock collect_streams()
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1696 >
2022-04-22 18:14:04 +00:00
Mathieu Duponchelle
4ef3b1ad8f
videoaggregator: keep old buffer when processing a MISSING_DATA gap
...
GAP events flagged with MISSING_DATA are transformed into GAP buffers
flagged with CORRUPTED.
In these cases, it is preferable to simply keep rendering the previous
buffer (if there was one) instead of flashing the pad in and out of
view.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/708 >
2022-04-22 17:43:50 +00:00
Mathieu Duponchelle
7988acad36
compositor: fix prepare_frame obscuring check
...
A pad without a buffer or with a GAP buffer cannot obscure a
pad below it. Ignore those when considering whether a pad should
be drawn.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/708 >
2022-04-22 17:43:50 +00:00
Mathieu Duponchelle
cc3a79d7f1
compositor: a pad without a frame can't obscure the background
...
Skip those when considering whether the background should be
drawn
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/708 >
2022-04-22 17:43:50 +00:00
Mathieu Duponchelle
da25b95bdf
aggregator: forward gap event information to gap buffer
...
When the GAP event was flagged with MISSING_DATA, subclasses
may want to adopt a different behaviour, for example by repeating
the last buffer.
As we turn these gap events into gap buffers, we need to flag
those, we do so with a new custom meta.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/708 >
2022-04-22 17:43:50 +00:00
Xavier Claessens
07a71e0563
Update proxy-libintl wrap to 0.4
...
It has fixes for Windows static build.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2262 >
2022-04-22 15:36:40 +00:00
Sangchul Lee
c5b1eecb69
webrtcbin: Avoid access of freed memory
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2256 >
2022-04-22 14:45:05 +00:00
Tristan Matthews
27dea62304
mp4mux: fix spelling
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2241 >
2022-04-22 14:07:57 +00:00
He Junyan
277aa12b86
va: h264enc: Do not let L0 number surplus the HW limitation.
...
The algorithm to calculate the L0/L1 number may let the L0 number
surplus the HW limitation. We should ensure that limitation after
that calculation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2202 >
2022-04-22 13:32:21 +00:00
Olivier Crête
2613930372
videoscale: Add test to ensure that non-scaled metas are kept
...
Just make sure that we're not breaking non-scaled metas
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1630 >
2022-04-22 13:00:01 +00:00
James Cowgill
2290af332b
videoscale: Add test for transform_meta function
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1630 >
2022-04-22 13:00:01 +00:00
James Cowgill
c8a24146c4
videoscale: Don't copy scaled metas
...
Returning TRUE from the `transform_meta` function tells
GstBaseTransform to copy the meta into the new buffer. If videoscale
has already transformed a meta by scaling it, it should always return
FALSE to avoid duplicating the meta.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1630 >
2022-04-22 13:00:01 +00:00
Nirbheek Chauhan
52d7370311
x11: Fix unused variable warnings
...
These are emitted when XInput 2 is not available.
```
../subprojects/gst-plugins-base/sys/ximage/ximagesink.c: In function ‘gst_x_image_sink_handle_xevents’:
../subprojects/gst-plugins-base/sys/ximage/ximagesink.c:696:29: warning: unused variable ‘state’ [-Wunused-variable]
696 | GstNavigationModifierType state = GST_NAVIGATION_MODIFIER_NONE;
| ^~~~~
../subprojects/gst-plugins-base/sys/ximage/ximagesink.c:694:35: warning: unused variable ‘touch_frame_open’ [-Wunused-variable]
694 | gboolean pointer_moved = FALSE, touch_frame_open = FALSE;
| ^~~~~~~~~~~~~~~~
../subprojects/gst-plugins-base/sys/xvimage/xvimagesink.c: In function ‘gst_xv_image_sink_handle_xevents’:
../subprojects/gst-plugins-base/sys/xvimage/xvimagesink.c:427:35: warning: unused variable ‘touch_frame_open’ [-Wunused-variable]
427 | gboolean pointer_moved = FALSE, touch_frame_open = FALSE;
| ^~~~~~~~~~~~~~~~
../subprojects/gst-plugins-base/sys/xvimage/xvimagesink.c:426:29: warning: unused variable ‘state’ [-Wunused-variable]
426 | GstNavigationModifierType state = GST_NAVIGATION_MODIFIER_NONE;
| ^~~~~
```
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2093 >
2022-04-22 12:26:55 +00:00