From ffb8476a38ec5c56a19decb3d9dfe35b82190d3b Mon Sep 17 00:00:00 2001 From: Christoph Reiter Date: Wed, 23 May 2018 21:10:00 +0200 Subject: [PATCH] wasapisink: fix missing unlock in case IAudioClient_Start fails https://bugzilla.gnome.org/show_bug.cgi?id=796354 --- sys/wasapi/gstwasapisink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/wasapi/gstwasapisink.c b/sys/wasapi/gstwasapisink.c index c636bca67a..f9992df417 100644 --- a/sys/wasapi/gstwasapisink.c +++ b/sys/wasapi/gstwasapisink.c @@ -613,7 +613,8 @@ gst_wasapi_sink_write (GstAudioSink * asink, gpointer data, guint length) GST_OBJECT_LOCK (self); if (self->client_needs_restart) { hr = IAudioClient_Start (self->client); - HR_FAILED_AND (hr, IAudioClient::Start, length = 0; goto beach); + HR_FAILED_AND (hr, IAudioClient::Start, + GST_OBJECT_UNLOCK (self); length = 0; goto beach); self->client_needs_restart = FALSE; } GST_OBJECT_UNLOCK (self);