From fd830868bf48d210c5ffa03ffd9d52bfbbf552d6 Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Fri, 27 Sep 2019 20:08:39 +0900 Subject: [PATCH] gst-play: Handle KeyDown event instead of KeyUp on Win32 keyboard handler To handle long press case, KeyDown input should be handled instead of KeyUp. Note that OS will take care of the sensitivity of KeyDown event, so we can safely assume one KeyDown as one input. That will not break user experience. --- tools/gst-play-kb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/gst-play-kb.c b/tools/gst-play-kb.c index 8d08758945..9c6cf43fb6 100644 --- a/tools/gst-play-kb.c +++ b/tools/gst-play-kb.c @@ -155,7 +155,7 @@ gst_play_kb_source_cb (Win32KeyHandler * handler) if (PeekConsoleInput (h_input, &buffer, 1, &n) && n == 1) { ReadConsoleInput (h_input, &buffer, 1, &n); - if (buffer.EventType == KEY_EVENT && !buffer.Event.KeyEvent.bKeyDown) { + if (buffer.EventType == KEY_EVENT && buffer.Event.KeyEvent.bKeyDown) { gchar key_val[2] = { 0 }; switch (buffer.Event.KeyEvent.wVirtualKeyCode) {