From fa710a59aad8d7e586fd1def81f4e4eb130ab9a0 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Wed, 4 Oct 2017 17:42:45 +0200 Subject: [PATCH] decodebin3: Don't take the lock when creating a new input We only need to take the input lock when adding/removing inputs from the list. --- gst/playback/gstdecodebin3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/playback/gstdecodebin3.c b/gst/playback/gstdecodebin3.c index 7c3e887097..e10fd1058b 100644 --- a/gst/playback/gstdecodebin3.c +++ b/gst/playback/gstdecodebin3.c @@ -940,13 +940,13 @@ gst_decodebin3_request_new_pad (GstElement * element, GstPadTemplate * temp, /* We are ignoring names for the time being, not sure it makes any sense * within the context of decodebin3 ... */ - INPUT_LOCK (dbin); input = create_new_input (dbin, FALSE); if (input) { + INPUT_LOCK (dbin); dbin->other_inputs = g_list_append (dbin->other_inputs, input); res = input->ghost_sink; + INPUT_UNLOCK (dbin); } - INPUT_UNLOCK (dbin); return res; }