From f7e70e5261c97f20b9950efe5c4d64ebaa4665ba Mon Sep 17 00:00:00 2001
From: Seungha Yang <seungha@centricular.com>
Date: Wed, 8 Jan 2025 00:56:45 +0900
Subject: [PATCH] d3d12mipmapping: Add mip-levels property
Generating full levels would result in waste of GPU resource
depending on rendering usecase. Adding a property to make it
controllable
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8255>
---
.../docs/plugins/gst_plugins_cache.json | 16 +++++++++-
.../sys/d3d12/gstd3d12mipmapping.cpp | 30 ++++++++++++++++++-
2 files changed, 44 insertions(+), 2 deletions(-)
diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
index eecf23bac2..b5f514ccaf 100644
--- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
+++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
@@ -14767,7 +14767,7 @@
"presence": "always"
},
"src": {
- "caps": "video/x-raw(memory:D3D12Memory):\n format: RGBA\n width: [ 1, 2147483647 ]\n height: [ 1, 2147483647 ]\n framerate: [ 0/1, 2147483647/1 ]\n\nvideo/x-raw(memory:D3D12Memory, meta:GstVideoOverlayComposition):\n format: RGBA\n width: [ 1, 2147483647 ]\n height: [ 1, 2147483647 ]\n framerate: [ 0/1, 2147483647/1 ]\n",
+ "caps": "video/x-raw(memory:D3D12Memory):\n format: { VUYA, RGBA, AYUV64, RGBA64_LE }\n width: [ 1, 2147483647 ]\n height: [ 1, 2147483647 ]\n framerate: [ 0/1, 2147483647/1 ]\n\nvideo/x-raw(memory:D3D12Memory, meta:GstVideoOverlayComposition):\n format: { VUYA, RGBA, AYUV64, RGBA64_LE }\n width: [ 1, 2147483647 ]\n height: [ 1, 2147483647 ]\n framerate: [ 0/1, 2147483647/1 ]\n",
"direction": "src",
"presence": "always"
}
@@ -14786,6 +14786,20 @@
"readable": true,
"type": "guint",
"writable": true
+ },
+ "mip-levels": {
+ "blurb": "Mipmap levels to use (0 = maximum level)",
+ "conditionally-available": false,
+ "construct": false,
+ "construct-only": false,
+ "controllable": false,
+ "default": "0",
+ "max": "65535",
+ "min": "0",
+ "mutable": "null",
+ "readable": true,
+ "type": "guint",
+ "writable": true
}
},
"rank": "none"
diff --git a/subprojects/gst-plugins-bad/sys/d3d12/gstd3d12mipmapping.cpp b/subprojects/gst-plugins-bad/sys/d3d12/gstd3d12mipmapping.cpp
index 2216db35d1..64f149cfa1 100644
--- a/subprojects/gst-plugins-bad/sys/d3d12/gstd3d12mipmapping.cpp
+++ b/subprojects/gst-plugins-bad/sys/d3d12/gstd3d12mipmapping.cpp
@@ -41,6 +41,7 @@
#include <queue>
#include <wrl.h>
#include <atomic>
+#include <math.h>
/* *INDENT-OFF* */
using namespace Microsoft::WRL;
@@ -75,9 +76,11 @@ enum
{
PROP_0,
PROP_ASYNC_DEPTH,
+ PROP_MIP_LEVELS,
};
#define DEFAULT_ASYNC_DEPTH 0
+#define DEFAULT_MIP_LEVELS 0
/* *INDENT-OFF* */
struct MipMappingContext
@@ -128,6 +131,7 @@ struct GstD3D12MipMappingPrivate
D3D12_BOX prev_in_rect = { };
std::atomic<guint> async_depth = { DEFAULT_ASYNC_DEPTH };
+ std::atomic<guint> mip_levels = { DEFAULT_MIP_LEVELS };
std::mutex lock;
};
@@ -185,6 +189,12 @@ gst_d3d12_mip_mapping_class_init (GstD3D12MipMappingClass * klass)
(GParamFlags) (GST_PARAM_MUTABLE_PLAYING |
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
+ g_object_class_install_property (object_class, PROP_MIP_LEVELS,
+ g_param_spec_uint ("mip-levels", "Mip Levels",
+ "Mipmap levels to use (0 = maximum level)",
+ 0, G_MAXUINT16, DEFAULT_MIP_LEVELS,
+ (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
+
gst_element_class_add_static_pad_template (element_class, &sink_template);
gst_element_class_add_static_pad_template (element_class, &src_template);
@@ -245,6 +255,9 @@ gst_d3d12_mip_mapping_set_property (GObject * object, guint prop_id,
case PROP_ASYNC_DEPTH:
priv->async_depth = g_value_get_uint (value);
break;
+ case PROP_MIP_LEVELS:
+ priv->mip_levels = g_value_get_uint (value);
+ break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
@@ -262,6 +275,9 @@ gst_d3d12_mip_mapping_get_property (GObject * object, guint prop_id,
case PROP_ASYNC_DEPTH:
g_value_set_uint (value, priv->async_depth);
break;
+ case PROP_MIP_LEVELS:
+ g_value_set_uint (value, priv->mip_levels);
+ break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
@@ -771,6 +787,8 @@ gst_d3d12_mip_mapping_decide_allocation (GstBaseTransform * trans,
GstQuery * query)
{
auto filter = GST_D3D12_BASE_FILTER (trans);
+ auto self = GST_D3D12_MIP_MAPPING (trans);
+ auto priv = self->priv;
GstCaps *outcaps = nullptr;
GstBufferPool *pool = nullptr;
guint size, min = 0, max = 0;
@@ -819,8 +837,18 @@ gst_d3d12_mip_mapping_decide_allocation (GstBaseTransform * trans,
GST_D3D12_ALLOCATION_FLAG_DEFAULT, resource_flags,
D3D12_HEAP_FLAG_SHARED);
+ guint mip_levels = priv->mip_levels;
+ if (mip_levels != 0) {
+ guint max_levels = 1 + (guint) floor (log2 (MAX (info.width, info.height)));
+ GST_DEBUG_OBJECT (self, "Requested mip levels %d, max levels %d",
+ mip_levels, max_levels);
+
+ if (max_levels <= mip_levels)
+ mip_levels = 0;
+ }
+
/* Auto generate mip maps */
- gst_d3d12_allocation_params_set_mip_levels (d3d12_params, 0);
+ gst_d3d12_allocation_params_set_mip_levels (d3d12_params, mip_levels);
gst_buffer_pool_config_set_d3d12_allocation_params (config, d3d12_params);
gst_d3d12_allocation_params_free (d3d12_params);