From f7ae4288a29daa6d5d44b26c27d4431e497d181a Mon Sep 17 00:00:00 2001 From: Ognyan Tonchev Date: Wed, 17 Sep 2014 16:37:11 +0200 Subject: [PATCH] rtpbin: do not leak encsink pad in error case https://bugzilla.gnome.org/show_bug.cgi?id=736807 --- gst/rtpmanager/gstrtpbin.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gst/rtpmanager/gstrtpbin.c b/gst/rtpmanager/gstrtpbin.c index 9b1b86a9f4..32472d92d7 100644 --- a/gst/rtpmanager/gstrtpbin.c +++ b/gst/rtpmanager/gstrtpbin.c @@ -3663,16 +3663,16 @@ create_rtcp (GstRtpBin * rtpbin, GstPadTemplate * templ, const gchar * name) GstPadLinkReturn ret; GST_DEBUG_OBJECT (rtpbin, "linking RTCP encoder"); - ename = g_strdup_printf ("rtcp_sink_%d", sessid); - encsink = gst_element_get_static_pad (encoder, ename); - g_free (ename); + ename = g_strdup_printf ("rtcp_src_%d", sessid); encsrc = gst_element_get_static_pad (encoder, ename); g_free (ename); - if (encsrc == NULL) goto enc_src_failed; + ename = g_strdup_printf ("rtcp_sink_%d", sessid); + encsink = gst_element_get_static_pad (encoder, ename); + g_free (ename); if (encsink == NULL) goto enc_sink_failed;