From f5b068b26ce71a7025bc23d589dc5a14e6461317 Mon Sep 17 00:00:00 2001
From: "Jan Alexander Steffens (heftig)" <jsteffens@make.tv>
Date: Wed, 27 Nov 2019 15:36:07 +0100
Subject: [PATCH] rtmp2: Minor changes

- Remove an unneeded initialization to zero from AmfParser
- Add missing initialization to gst_amf_serialize_command_valist
- Add a g_return_if_fail to gst_rtmp_connection_request_window_size

https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/878
---
 gst/rtmp2/rtmp/amf.c            | 3 ++-
 gst/rtmp2/rtmp/rtmpconnection.c | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/gst/rtmp2/rtmp/amf.c b/gst/rtmp2/rtmp/amf.c
index a6f5b3be0e..895570f499 100644
--- a/gst/rtmp2/rtmp/amf.c
+++ b/gst/rtmp2/rtmp/amf.c
@@ -893,7 +893,6 @@ gst_amf_parse_command (const guint8 * data, gsize size,
   AmfParser parser = {
     .data = data,
     .size = size,
-    .recursion_depth = 0,
   };
   GstAmfNode *node1 = NULL, *node2 = NULL;
   GPtrArray *args = NULL;
@@ -1119,6 +1118,8 @@ gst_amf_serialize_command_valist (gdouble transaction_id,
   g_return_val_if_fail (command_name, NULL);
   g_return_val_if_fail (argument, NULL);
 
+  init_static ();
+
   GST_LOG ("Serializing command '%s', transid %.0f", command_name,
       transaction_id);
 
diff --git a/gst/rtmp2/rtmp/rtmpconnection.c b/gst/rtmp2/rtmp/rtmpconnection.c
index 8c14516b04..d895f8e5c6 100644
--- a/gst/rtmp2/rtmp/rtmpconnection.c
+++ b/gst/rtmp2/rtmp/rtmpconnection.c
@@ -989,6 +989,8 @@ gst_rtmp_connection_request_window_size (GstRtmpConnection * connection,
     .param = window_ack_size,
   };
 
+  g_return_if_fail (GST_IS_RTMP_CONNECTION (connection));
+
   if (connection->out_window_ack_size == window_ack_size)
     return;