From f3c162cc85eed15b17b9ceda904fcea10711e172 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Tue, 4 Oct 2022 19:17:15 -0300 Subject: [PATCH] validate: launcher: Add a argument to avoid rereuning flaky tests Part-of: --- subprojects/gst-devtools/validate/launcher/baseclasses.py | 2 +- subprojects/gst-devtools/validate/launcher/main.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-devtools/validate/launcher/baseclasses.py b/subprojects/gst-devtools/validate/launcher/baseclasses.py index 16c47cd595..bbe0ba1e16 100644 --- a/subprojects/gst-devtools/validate/launcher/baseclasses.py +++ b/subprojects/gst-devtools/validate/launcher/baseclasses.py @@ -2176,7 +2176,7 @@ class _TestsLauncher(Loggable): self.reporter.after_test(test) return False - if retry_on_failures or test.max_retries: + if retry_on_failures or test.max_retries and not self.options.no_retry_on_failures: if not self.options.redirect_logs: test.copy_logfiles() to_retry.append(test) diff --git a/subprojects/gst-devtools/validate/launcher/main.py b/subprojects/gst-devtools/validate/launcher/main.py index 5f9cd5ff55..33658210cd 100644 --- a/subprojects/gst-devtools/validate/launcher/main.py +++ b/subprojects/gst-devtools/validate/launcher/main.py @@ -522,6 +522,8 @@ class LauncherConfig(Loggable): " at the same time") parser.add_argument('--retry-on-failures', dest="retry_on_failures", action="store_true", help="Re-try tests that produce unexpected results") + parser.add_argument('--no-retry-on-failures', dest="no_retry_on_failures", action="store_true", + help="Disable retrying on failure, event for known to be flaky tests.") parser.add_argument('--html', dest="html", action="store_true", help="Write logs as html") dir_group = parser.add_argument_group(