From f3bafece3616a3d737c07da4f3e4bbf9cad12d40 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Mon, 21 Nov 2005 18:44:02 +0000 Subject: [PATCH] gst/playback/gstplaybin.c (gen_audio_element) Original commit message from CVS: 2005-11-21 Andy Wingo * gst/playback/gstplaybin.c (gen_audio_element) (gen_video_element): Use the new MISSING_PLUGIN core error category. --- ChangeLog | 4 ++++ gst/playback/gstplaybin.c | 6 ++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7ca1d9160a..f79018d700 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2005-11-21 Andy Wingo + * gst/playback/gstplaybin.c (gen_audio_element) + (gen_video_element): Use the new MISSING_PLUGIN core error + category. + * ext/vorbis/vorbisdec.c (vorbis_dec_sink_event): * gst/videorate/gstvideorate.c (gst_videorate_event): * ext/theora/theoradec.c (theora_dec_sink_event): diff --git a/gst/playback/gstplaybin.c b/gst/playback/gstplaybin.c index 28c2e229f0..1e119f42a1 100644 --- a/gst/playback/gstplaybin.c +++ b/gst/playback/gstplaybin.c @@ -407,7 +407,7 @@ gen_video_element (GstPlayBin * play_bin) /* FIXME: this warrants adding a CORE error category for missing * elements/plugins */ if (sink == NULL) { - GST_ELEMENT_ERROR (play_bin, CORE, FAILED, + GST_ELEMENT_ERROR (play_bin, CORE, MISSING_PLUGIN, (_("Both autovideosink and xvimagesink elements are missing.")), (NULL)); return NULL; @@ -536,10 +536,8 @@ gen_audio_element (GstPlayBin * play_bin) if (sink == NULL) { sink = gst_element_factory_make ("alsasink", "audiosink"); } - /* FIXME: this warrants adding a CORE error category for missing - * elements/plugins */ if (sink == NULL) { - GST_ELEMENT_ERROR (play_bin, CORE, FAILED, + GST_ELEMENT_ERROR (play_bin, CORE, MISSING_PLUGIN, (_("Both autoaudiosink and alsasink elements are missing.")), (NULL)); return NULL; }