diff --git a/subprojects/gst-devtools/meson.build b/subprojects/gst-devtools/meson.build index 8d8fc6c254..4c53c83cae 100644 --- a/subprojects/gst-devtools/meson.build +++ b/subprojects/gst-devtools/meson.build @@ -127,20 +127,27 @@ if gst_debug_disabled and cc.has_argument('-Wno-unused') add_project_arguments('-Wno-unused', language: 'c') endif +# NOTE: Keep entries alphabetically sorted warning_flags = [ - '-Wmissing-declarations', - '-Wmissing-prototypes', - '-Wredundant-decls', - '-Wundef', - '-Wwrite-strings', + '-Waddress', + '-Waggregate-return', '-Wformat', '-Wformat-security', + '-Wimplicit-fallthrough=3', '-Winit-self', + '-Wmissing-declarations', '-Wmissing-include-dirs', - '-Waddress', + '-Wmissing-parameter-type', + '-Wmissing-prototypes', '-Wno-multichar', - '-Wvla', + '-Wold-style-definition', '-Wpointer-arith', + '-Wredundant-decls', + '-Wshift-negative-value', + '-Wtype-limits', + '-Wundef', + '-Wvla', + '-Wwrite-strings', ] foreach extra_arg : warning_flags diff --git a/subprojects/gst-devtools/validate/gst/validate/gst-validate-scenario.c b/subprojects/gst-devtools/validate/gst/validate/gst-validate-scenario.c index 5b0f7b4332..2309028713 100644 --- a/subprojects/gst-devtools/validate/gst/validate/gst-validate-scenario.c +++ b/subprojects/gst-devtools/validate/gst/validate/gst-validate-scenario.c @@ -5181,7 +5181,7 @@ handle_bus_message (MessageData * d) case GST_MESSAGE_ERROR: is_error = TRUE; - /* Passthrough */ + /* FALLTHROUGH */ case GST_MESSAGE_EOS: { GstValidateAction *stop_action; @@ -7147,6 +7147,7 @@ _action_set_done (GstValidateAction * action) case GST_VALIDATE_EXECUTE_ACTION_ERROR: GST_VALIDATE_REPORT_ACTION (scenario, action, SCENARIO_ACTION_EXECUTION_ERROR, "Action %s failed", action->type); + /* FALLTHROUGH */ case GST_VALIDATE_EXECUTE_ACTION_ASYNC: case GST_VALIDATE_EXECUTE_ACTION_IN_PROGRESS: case GST_VALIDATE_EXECUTE_ACTION_NONE: