From eca452978aa61a9b17e9357c0b2365ccf0e01b26 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Fri, 16 Aug 2013 14:25:49 +0200 Subject: [PATCH] pad-monitor: Don't use signal that doesn't exist Note that we should just ensure we always get the pads from the parent --- validate/gst/validate/gst-validate-pad-monitor.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/validate/gst/validate/gst-validate-pad-monitor.c b/validate/gst/validate/gst-validate-pad-monitor.c index 3c54761cf5..b87a16b6d7 100644 --- a/validate/gst/validate/gst-validate-pad-monitor.c +++ b/validate/gst/validate/gst-validate-pad-monitor.c @@ -459,14 +459,6 @@ gst_validate_pad_monitor_check_late_serialized_events (GstValidatePadMonitor * g_ptr_array_remove_range (monitor->serialized_events, 0, i); } -void -_parent_set_cb (GstObject * object, GstObject * parent, - GstValidateMonitor * monitor) -{ - gst_validate_reporter_set_name (GST_VALIDATE_REPORTER (monitor), - g_strdup_printf ("%s:%s", GST_DEBUG_PAD_NAME (object))); -} - static void gst_validate_pad_monitor_dispose (GObject * object) { @@ -476,9 +468,6 @@ gst_validate_pad_monitor_dispose (GObject * object) if (pad) { if (monitor->pad_probe_id) gst_pad_remove_probe (pad, monitor->pad_probe_id); - - g_signal_handlers_disconnect_by_func (pad, (GCallback) _parent_set_cb, - monitor); } if (monitor->expected_segment) @@ -1657,7 +1646,8 @@ gst_validate_pad_monitor_do_setup (GstValidateMonitor * monitor) gst_validate_reporter_set_name (GST_VALIDATE_REPORTER (monitor), g_strdup_printf ("%s:%s", GST_DEBUG_PAD_NAME (pad))); - g_signal_connect (pad, "parent-set", (GCallback) _parent_set_cb, monitor); + if (G_UNLIKELY (GST_PAD_PARENT (pad) == NULL)) + GST_FIXME ("Saw a pad not belonging to any object"); return TRUE; }