From eb33462a15a90aec8b27634b5114a418d951f482 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 17 Feb 2005 17:56:39 +0000 Subject: [PATCH] Do not pass uninitialised values to setsockopt(). (fixes #167704) Original commit message from CVS: Do not pass uninitialised values to setsockopt(). (fixes #167704) --- ChangeLog | 7 +++++++ gst/tcp/gsttcpserversink.c | 10 ++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5b2473c58e..844ab6a036 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2005-02-17 Luca Ognibene + + Reviewed by: Tim-Philipp Müller + + * gst/tcp/gsttcpserversink.c: (gst_tcpserversink_init_send): + Don't pass uninitialised values to setsockopt(). (fixes #167704) + 2005-02-16 Ronald S. Bultje * gst/playback/gstplaybin.c: (add_sink): diff --git a/gst/tcp/gsttcpserversink.c b/gst/tcp/gsttcpserversink.c index 3a2df2ba14..4dd513afca 100644 --- a/gst/tcp/gsttcpserversink.c +++ b/gst/tcp/gsttcpserversink.c @@ -286,16 +286,18 @@ gst_tcpserversink_init_send (GstMultiFdSink * parent) this->server_sock.fd); /* make address reusable */ - if (setsockopt (this->server_sock.fd, SOL_SOCKET, SO_REUSEADDR, &ret, - sizeof (int)) < 0) { + ret = 1; + if (setsockopt (this->server_sock.fd, SOL_SOCKET, SO_REUSEADDR, + (void *) &ret, sizeof (ret)) < 0) { gst_tcp_socket_close (&this->server_sock.fd); GST_ELEMENT_ERROR (this, RESOURCE, SETTINGS, (NULL), ("Could not setsockopt: %s", g_strerror (errno))); return FALSE; } /* keep connection alive; avoids SIGPIPE during write */ - if (setsockopt (this->server_sock.fd, SOL_SOCKET, SO_KEEPALIVE, &ret, - sizeof (int)) < 0) { + ret = 1; + if (setsockopt (this->server_sock.fd, SOL_SOCKET, SO_KEEPALIVE, + (void *) &ret, sizeof (ret)) < 0) { gst_tcp_socket_close (&this->server_sock.fd); GST_ELEMENT_ERROR (this, RESOURCE, SETTINGS, (NULL), ("Could not setsockopt: %s", g_strerror (errno)));