From ea959add31e7c208a8a8b65c7d789fcef11de019 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Thu, 16 Dec 2010 08:47:56 -0300 Subject: [PATCH] basecamerasrc: Add some more logging Adds some more logging and always assume capture has started before start_capture is called. This helps on image captures that might call finish_capture directly from start_capture or before start_capture finishes. --- gst-libs/gst/basecamerabinsrc/gstbasecamerasrc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/basecamerabinsrc/gstbasecamerasrc.c b/gst-libs/gst/basecamerabinsrc/gstbasecamerasrc.c index a05418c588..7469f50fb7 100644 --- a/gst-libs/gst/basecamerabinsrc/gstbasecamerasrc.c +++ b/gst-libs/gst/basecamerabinsrc/gstbasecamerasrc.c @@ -222,6 +222,8 @@ gst_base_camera_src_start_capture (GstBaseCameraSrc * src) g_return_if_fail (klass->start_capture != NULL); + GST_DEBUG_OBJECT (src, "Starting capture"); + g_mutex_lock (src->capturing_mutex); if (src->capturing) { GST_WARNING_OBJECT (src, "Capturing already ongoing"); @@ -229,10 +231,12 @@ gst_base_camera_src_start_capture (GstBaseCameraSrc * src) return; } + src->capturing = TRUE; if (klass->start_capture (src)) { - src->capturing = TRUE; + GST_DEBUG_OBJECT (src, "Capture started"); g_object_notify (G_OBJECT (src), "ready-for-capture"); } else { + src->capturing = FALSE; GST_WARNING_OBJECT (src, "Failed to start capture"); } g_mutex_unlock (src->capturing_mutex); @@ -258,6 +262,7 @@ gst_base_camera_src_stop_capture (GstBaseCameraSrc * src) void gst_base_camera_src_finish_capture (GstBaseCameraSrc * self) { + GST_DEBUG_OBJECT (self, "Finishing capture"); g_return_if_fail (self->capturing); self->capturing = FALSE; g_object_notify (G_OBJECT (self), "ready-for-capture");