From e9b72257e27e7c8f69199119b85f46daa95910df Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Wed, 3 Aug 2011 13:12:18 -0300 Subject: [PATCH] camerabin2: Add a missing element check and remove TODO Add missing element checks for elements created at _init functions and remove TODO about it --- gst/camerabin2/gstcamerabin2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gst/camerabin2/gstcamerabin2.c b/gst/camerabin2/gstcamerabin2.c index 4a55cae4b7..0464ca0d72 100644 --- a/gst/camerabin2/gstcamerabin2.c +++ b/gst/camerabin2/gstcamerabin2.c @@ -1116,7 +1116,12 @@ gst_camera_bin_create_elements (GstCameraBin2 * camera) gint encbin_flags = 0; if (!camera->elements_created) { - /* TODO check that elements created in _init were really created */ + /* Check that elements created in _init were really created */ + if (!(camera->audio_capsfilter && camera->videobin_capsfilter && + camera->imagebin_capsfilter && camera->viewfinderbin_capsfilter)) { + missing_element_name = "capsfilter"; + goto missing_element; + } camera->video_encodebin = gst_element_factory_make ("encodebin", "video-encodebin");