FaSTTUBe/GST-Tensordecoder-ov_ep
35
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

gstglfiltershader: Free various props before set & during cleanup

Browse Source 
gst_object_replace() takes a reference so no need to dup object.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8978>
This commit is contained in:
Doug Nazar 2025-05-13 19:42:37 -04:00
parent 4fb0a06271
commit e4f60e44ee
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
subprojects/gst-plugins-base/ext/gl/gstglfiltershader.c
View File

@ -188,6 +188,10 @@ gst_gl_filtershader_finalize (GObject * object)
{ {
GstGLFilterShader *filtershader = GST_GL_FILTERSHADER (object); GstGLFilterShader *filtershader = GST_GL_FILTERSHADER (object);
if (filtershader->shader)
gst_object_unref (filtershader->shader);
filtershader->shader = NULL;
g_free (filtershader->vertex); g_free (filtershader->vertex);
filtershader->vertex = NULL; filtershader->vertex = NULL;
@ -211,7 +215,7 @@ gst_gl_filtershader_set_property (GObject * object, guint prop_id,
case PROP_SHADER: case PROP_SHADER:
GST_OBJECT_LOCK (filtershader); GST_OBJECT_LOCK (filtershader);
gst_object_replace ((GstObject **) & filtershader->shader, gst_object_replace ((GstObject **) & filtershader->shader,
g_value_dup_object (value)); g_value_get_object (value));
filtershader->new_source = FALSE; filtershader->new_source = FALSE;
GST_OBJECT_UNLOCK (filtershader); GST_OBJECT_UNLOCK (filtershader);
break; break;
@ -284,12 +288,6 @@ gst_gl_filtershader_get_property (GObject * object, guint prop_id,
static void static void
gst_gl_filtershader_gl_stop (GstGLBaseFilter * base) gst_gl_filtershader_gl_stop (GstGLBaseFilter * base)
{ {
GstGLFilterShader *filtershader = GST_GL_FILTERSHADER (base);
if (filtershader->shader)
gst_object_unref (filtershader->shader);
filtershader->shader = NULL;
GST_GL_BASE_FILTER_CLASS (parent_class)->gl_stop (base); GST_GL_BASE_FILTER_CLASS (parent_class)->gl_stop (base);
} }