From e308986807032dd9cf00629376677de6fc5221d5 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Wed, 9 Apr 2014 18:31:31 +0100 Subject: [PATCH] kate: fix implicit promotion to signed int breaking on largeish inputs Coverity 1139858, 1139857 --- ext/kate/gstkatespu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/kate/gstkatespu.c b/ext/kate/gstkatespu.c index 951ef0f02a..e256f86324 100644 --- a/ext/kate/gstkatespu.c +++ b/ext/kate/gstkatespu.c @@ -601,8 +601,8 @@ gst_kate_spu_decode_spu (GstKateEnc * ke, GstBuffer * buf, kate_region * kr, /* prefer relative sizes in case we're encoding for a different resolution that what the SPU was created for */ kr->metric = kate_millionths; - kr->x = 1000000 * x / ke->original_canvas_width; - kr->y = 1000000 * y / ke->original_canvas_height; + kr->x = 1000000 * (size_t) x / ke->original_canvas_width; + kr->y = 1000000 * (size_t) y / ke->original_canvas_height; kr->w = 1000000 * kb->width / ke->original_canvas_width; kr->h = 1000000 * kb->height / ke->original_canvas_height; } else {