FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nice: Rename local candidate filling function

Browse Source 
Rename it, and avoid using it on remote candidates, as it will put
the wrong value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8900>
This commit is contained in:
Olivier Crête 2025-04-25 16:33:39 -04:00 committed by GStreamer Marge Bot
parent 50c5191179
commit e2f07cf314
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
View File

@ -552,7 +552,7 @@ gst_webrtc_nice_add_stream (GstWebRTCICE * ice, guint session_id)
} }
static void static void
_fill_candidate_credentials (NiceAgent * agent, NiceCandidate * candidate) _fill_local_candidate_credentials (NiceAgent * agent, NiceCandidate * candidate)
{ {
if (!candidate->username || !candidate->password) { if (!candidate->username || !candidate->password) {
@ -592,7 +592,7 @@ _on_new_candidate (NiceAgent * agent, NiceCandidate * candidate,
} }
c = nice_candidate_copy (candidate); c = nice_candidate_copy (candidate);
_fill_candidate_credentials (agent, c); _fill_local_candidate_credentials (agent, c);
attr = nice_agent_generate_local_candidate_sdp (agent, c); attr = nice_agent_generate_local_candidate_sdp (agent, c);
@ -1216,8 +1216,7 @@ gst_webrtc_nice_get_selected_pair (GstWebRTCICE * ice,
if (stream) { if (stream) {
if (nice_agent_get_selected_pair (nice->priv->nice_agent, stream->stream_id, if (nice_agent_get_selected_pair (nice->priv->nice_agent, stream->stream_id,
NICE_COMPONENT_TYPE_RTP, &local_cand, &remote_cand)) { NICE_COMPONENT_TYPE_RTP, &local_cand, &remote_cand)) {
_fill_candidate_credentials (nice->priv->nice_agent, local_cand); _fill_local_candidate_credentials (nice->priv->nice_agent, local_cand);
_fill_candidate_credentials (nice->priv->nice_agent, remote_cand);
*local_stats = g_new0 (GstWebRTCICECandidateStats, 1); *local_stats = g_new0 (GstWebRTCICECandidateStats, 1);
_populate_candidate_stats (nice, local_cand, stream, *local_stats, TRUE); _populate_candidate_stats (nice, local_cand, stream, *local_stats, TRUE);