From e179a6b4dc6b6b266d95307a41fae414d4a137bd Mon Sep 17 00:00:00 2001 From: Gwenole Beauchesne Date: Mon, 19 Nov 2012 10:32:57 +0100 Subject: [PATCH] codecparsers: vc1: fix PTYPE for interlaced frames. Coverity found missing break in parse_frame_header_advanced() when determining PTYPE from FPTYPE for interlaced streams. https://bugzilla.gnome.org/show_bug.cgi?id=688626 Signed-off-by: Gwenole Beauchesne --- gst-libs/gst/codecparsers/gstvc1parser.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gst-libs/gst/codecparsers/gstvc1parser.c b/gst-libs/gst/codecparsers/gstvc1parser.c index 4ec9788316..3c2640e52c 100644 --- a/gst-libs/gst/codecparsers/gstvc1parser.c +++ b/gst-libs/gst/codecparsers/gstvc1parser.c @@ -924,30 +924,38 @@ parse_frame_header_advanced (GstBitReader * br, GstVC1FrameHdr * framehdr, case 0x00: case 0x02: framehdr->ptype = GST_VC1_PICTURE_TYPE_I; + break; case 0x01: case 0x03: framehdr->ptype = GST_VC1_PICTURE_TYPE_P; + break; case 0x04: case 0x06: framehdr->ptype = GST_VC1_PICTURE_TYPE_B; + break; case 0x05: case 0x07: framehdr->ptype = GST_VC1_PICTURE_TYPE_BI; + break; } } else { switch (pic->fptype) { case 0x00: case 0x01: framehdr->ptype = GST_VC1_PICTURE_TYPE_I; + break; case 0x02: case 0x03: framehdr->ptype = GST_VC1_PICTURE_TYPE_P; + break; case 0x04: case 0x05: framehdr->ptype = GST_VC1_PICTURE_TYPE_B; + break; case 0x06: case 0x07: framehdr->ptype = GST_VC1_PICTURE_TYPE_BI; + break; } } } else