va: vp9dec: Minor cleanups.
Added a comment with a future to-do, enhanced another comment and fixed a typo in an error log message. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2417>
This commit is contained in:
parent
b45754b478
commit
de19e8a84f
@ -200,9 +200,13 @@ _check_resolution_change (GstVaVp9Dec * self, GstVp9Picture * picture)
|
|||||||
|
|
||||||
self->need_negotiation = TRUE;
|
self->need_negotiation = TRUE;
|
||||||
if (!gst_video_decoder_negotiate (GST_VIDEO_DECODER (self))) {
|
if (!gst_video_decoder_negotiate (GST_VIDEO_DECODER (self))) {
|
||||||
GST_ERROR_OBJECT (self, "Resolution changes, but failed to"
|
GST_ERROR_OBJECT (self, "Resolution changed, but failed to"
|
||||||
" negotiate with downstream");
|
" negotiate with downstream");
|
||||||
return FALSE;
|
return FALSE;
|
||||||
|
|
||||||
|
/* @TODO: if negotiation fails, decoder should resize output
|
||||||
|
* frame. For that we would need an auxiliar allocator, and
|
||||||
|
* later use GstVaFilter or GstVideoConverter. */
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -544,9 +548,9 @@ gst_va_vp9_dec_negotiate (GstVideoDecoder * decoder)
|
|||||||
self->need_negotiation = FALSE;
|
self->need_negotiation = FALSE;
|
||||||
|
|
||||||
need_open = TRUE;
|
need_open = TRUE;
|
||||||
/* The driver for VP9 should have the ability to handle the dynamical
|
/* VP9 profile entry should have the ability to handle dynamical
|
||||||
resolution changes. So if only the resolution changes, we should not
|
* resolution changes. If only the resolution changes, we should not
|
||||||
re-create the config and context. */
|
* re-create the config and context. */
|
||||||
if (gst_va_decoder_is_open (base->decoder)) {
|
if (gst_va_decoder_is_open (base->decoder)) {
|
||||||
VAProfile cur_profile;
|
VAProfile cur_profile;
|
||||||
guint cur_rtformat;
|
guint cur_rtformat;
|
||||||
|
Loading…
x
Reference in New Issue
Block a user