From ddc95f5b8c50fa7f65c4a8c8a8d95c44c1bac26c Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Wed, 14 Aug 2013 15:58:34 -0300 Subject: [PATCH] pad-monitor: only do complete caps checks on setcaps On get caps it is acceptable to have missing fields to simplify caps negotiation --- validate/gst/qa/gst-qa-pad-monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/validate/gst/qa/gst-qa-pad-monitor.c b/validate/gst/qa/gst-qa-pad-monitor.c index 74f4417489..c19238cf64 100644 --- a/validate/gst/qa/gst-qa-pad-monitor.c +++ b/validate/gst/qa/gst-qa-pad-monitor.c @@ -1526,7 +1526,6 @@ gst_qa_pad_monitor_getcaps_func (GstPad * pad) /* We shouldn't need to lock the parent as this doesn't modify * other monitors, just does some peer_pad_caps */ GST_QA_MONITOR_LOCK (pad_monitor); - gst_qa_pad_monitor_check_caps_complete (pad_monitor, ret); if (GST_PAD_DIRECTION (pad) == GST_PAD_SINK) { gst_qa_pad_monitor_check_caps_fields_proxied (pad_monitor, ret); @@ -1550,6 +1549,8 @@ gst_qa_pad_monitor_setcaps_func (GstPad * pad, GstCaps * caps) GST_QA_PAD_MONITOR_PARENT_LOCK (pad_monitor); GST_QA_MONITOR_LOCK (pad_monitor); + gst_qa_pad_monitor_check_caps_complete (pad_monitor, caps); + if (caps) { structure = gst_caps_get_structure (caps, 0); if (gst_structure_n_fields (pad_monitor->pending_setcaps_fields)) {