From dd738842e42d269f15d4ee8b17d2c4e26f5885c8 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Sat, 31 Oct 2015 23:28:20 +1100 Subject: [PATCH] glbufferpool: explicitly initialize a possibly uninitialized variable The ret variable may be uninitialized and so its contents were undefined and the results were erratic (failing with glvideomixer, succeeding in other cases) P.S. No idea why gcc/clang et al never picked up on this like they normally do (probably due to some optimisation pass figuring out it's only set once...) --- gst-libs/gst/gl/gstglbufferpool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst-libs/gst/gl/gstglbufferpool.c b/gst-libs/gst/gl/gstglbufferpool.c index ed91eaa6d2..784964f149 100644 --- a/gst-libs/gst/gl/gstglbufferpool.c +++ b/gst-libs/gst/gl/gstglbufferpool.c @@ -99,7 +99,7 @@ gst_gl_buffer_pool_set_config (GstBufferPool * pool, GstStructure * config) guint max_align, n; GstAllocator *allocator = NULL; GstAllocationParams alloc_params; - gboolean reset = TRUE, ret; + gboolean reset = TRUE, ret = TRUE; gint p; if (!gst_buffer_pool_config_get_params (config, &caps, NULL, &min_buffers,