From dc81abe9eefbd1e928ba01f19845edf265745d84 Mon Sep 17 00:00:00 2001
From: Seungha Yang <seungha@centricular.com>
Date: Wed, 22 Jan 2025 19:37:02 +0900
Subject: [PATCH] cudacompositor: Fix memory leak

gst_cuda_compositor_upload_frame() returns buffers with increased
refcount already

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8335>
---
 subprojects/gst-plugins-bad/sys/nvcodec/gstcudacompositor.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/subprojects/gst-plugins-bad/sys/nvcodec/gstcudacompositor.cpp b/subprojects/gst-plugins-bad/sys/nvcodec/gstcudacompositor.cpp
index da8926ee07..7cbe683285 100644
--- a/subprojects/gst-plugins-bad/sys/nvcodec/gstcudacompositor.cpp
+++ b/subprojects/gst-plugins-bad/sys/nvcodec/gstcudacompositor.cpp
@@ -663,10 +663,10 @@ gst_cuda_compositor_pad_prepare_frame (GstVideoAggregatorPad * pad,
           &pad->info, buffer, (GstMapFlags) (GST_MAP_READ | GST_MAP_CUDA))) {
     GST_ERROR_OBJECT (self, "Couldn't map frame");
     gst_buffer_unref (buffer);
+    return FALSE;
   }
 
-  prepared_frame->buffer = buffer;
-  priv->prepared_buf = gst_buffer_ref (buffer);
+  priv->prepared_buf = buffer;
 
   return TRUE;
 }