From d3acb2b01a7a05dc0276f95f4830d5879bd0e42c Mon Sep 17 00:00:00 2001 From: Brendan Long Date: Mon, 1 Jul 2013 12:52:43 -0600 Subject: [PATCH] playbin: Post an error message if a stream combiner doesn't return a request pad. --- gst/playback/gstplaybin2.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c index d4976b350d..f26a5f627f 100644 --- a/gst/playback/gstplaybin2.c +++ b/gst/playback/gstplaybin2.c @@ -3100,6 +3100,8 @@ pad_added_cb (GstElement * decodebin, GstPad * pad, GstSourceGroup * group) changed = TRUE; GST_DEBUG_OBJECT (playbin, "linked pad %s:%s to combiner %p", GST_DEBUG_PAD_NAME (pad), combine->combiner); + } else { + goto request_pad_failed; } } else { /* no combiner, don't configure anything, we'll link the new pad directly to @@ -3171,6 +3173,12 @@ link_failed: GST_SOURCE_GROUP_UNLOCK (group); goto done; } +request_pad_failed: + GST_ELEMENT_ERROR (playbin, CORE, PAD, + ("Internal playbin error."), + ("Failed to get request pad from combiner %p.", combine->combiner)); + GST_SOURCE_GROUP_UNLOCK (group); + goto done; } /* called when a pad is removed from the uridecodebin. We unlink the pad from