From d013481d8ee483b4da7470c9610c99d72b8829c0 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 26 Jul 2011 14:10:33 +0200 Subject: [PATCH] x11: let old pool drain Let the old pool drain without deactivating it, some elements might still be using it. --- sys/ximage/ximagesink.c | 4 ++-- sys/xvimage/xvimagesink.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/ximage/ximagesink.c b/sys/ximage/ximagesink.c index 35d97d2af3..7413b78253 100644 --- a/sys/ximage/ximagesink.c +++ b/sys/ximage/ximagesink.c @@ -1150,8 +1150,8 @@ gst_ximagesink_setcaps (GstBaseSink * bsink, GstCaps * caps) /* unref the old sink */ if (oldpool) { - /* deactivate */ - gst_buffer_pool_set_active (oldpool, FALSE); + /* we don't deactivate, some elements might still be using it, it will be + * deactivated when the last ref is gone */ gst_object_unref (oldpool); } g_mutex_unlock (ximagesink->flow_lock); diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c index 22811ce25e..2533d3ab7d 100644 --- a/sys/xvimage/xvimagesink.c +++ b/sys/xvimage/xvimagesink.c @@ -1660,8 +1660,8 @@ gst_xvimagesink_setcaps (GstBaseSink * bsink, GstCaps * caps) /* unref the old sink */ if (oldpool) { - /* deactivate */ - gst_buffer_pool_set_active (oldpool, FALSE); + /* we don't deactivate, some elements might still be using it, it will + * be deactivated when the last ref is gone */ gst_object_unref (oldpool); }