FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

rtmpsrc: plug memory-leaks

Browse Source 
https://bugzilla.gnome.org/show_bug.cgi?id=756001
This commit is contained in:
Havard Graff 2015-10-01 11:18:52 +02:00 committed by Sebastian Dröge
parent 458bafe9e3
commit cb20105aa5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ext/rtmp/gstrtmpsrc.c
View File

@ -234,8 +234,11 @@ gst_rtmp_src_uri_set_uri (GstURIHandler * handler, const gchar * uri,
GST_ERROR_OBJECT (src, "Failed to parse URI %s", uri); GST_ERROR_OBJECT (src, "Failed to parse URI %s", uri);
g_set_error (error, GST_URI_ERROR, GST_URI_ERROR_BAD_URI, g_set_error (error, GST_URI_ERROR, GST_URI_ERROR_BAD_URI,
"Could not parse RTMP URI"); "Could not parse RTMP URI");
/* FIXME: we should not be freeing RTMP internals to avoid leaking */
free (playpath.av_val);
return FALSE; return FALSE;
} }
free (playpath.av_val);
src->uri = g_strdup (uri); src->uri = g_strdup (uri);
} }
@ -559,7 +562,6 @@ static gboolean
gst_rtmp_src_start (GstBaseSrc * basesrc) gst_rtmp_src_start (GstBaseSrc * basesrc)
{ {
GstRTMPSrc *src; GstRTMPSrc *src;
gchar *uri_copy;
src = GST_RTMP_SRC (basesrc); src = GST_RTMP_SRC (basesrc);
@ -572,13 +574,11 @@ gst_rtmp_src_start (GstBaseSrc * basesrc)
src->last_timestamp = 0; src->last_timestamp = 0;
src->discont = TRUE; src->discont = TRUE;
uri_copy = g_strdup (src->uri);
src->rtmp = RTMP_Alloc (); src->rtmp = RTMP_Alloc ();
RTMP_Init (src->rtmp); RTMP_Init (src->rtmp);
if (!RTMP_SetupURL (src->rtmp, uri_copy)) { if (!RTMP_SetupURL (src->rtmp, src->uri)) {
GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, (NULL), GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, (NULL),
("Failed to setup URL '%s'", src->uri)); ("Failed to setup URL '%s'", src->uri));
g_free (uri_copy);
RTMP_Free (src->rtmp); RTMP_Free (src->rtmp);
src->rtmp = NULL; src->rtmp = NULL;
return FALSE; return FALSE;