From c91187c187d779ae7d6e6ec0a8ac206e7d9fde67 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Thu, 23 Nov 2017 23:01:52 +1100 Subject: [PATCH] viv-fb: Don't destroy the native FB display It causes crashes in applications because the result of fbGetDisplay() might be in use elsewhere in the application and Vivante doesn't seem to do any refcounting --- gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c b/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c index 48815e52fa..b90273e4ec 100644 --- a/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c +++ b/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c @@ -59,8 +59,8 @@ gst_gl_display_viv_fb_finalize (GObject * object) { GstGLDisplayVivFB *display_viv_fb = GST_GL_DISPLAY_VIV_FB (object); - if (display_viv_fb->display) - fbDestroyDisplay (display_viv_fb->display); + // We don't destroy the FB Display - it causes crashes in applications + // because Vivante doesn't seem to do any refcounting G_OBJECT_CLASS (gst_gl_display_viv_fb_parent_class)->finalize (object); }