From c6e832594509818b22b6c20e395b40e77be260f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= Date: Thu, 13 Dec 2018 19:16:11 -0500 Subject: [PATCH] rtpjitterbuffer test: Stop jitterbuffer before pads to avoid race The teardown of the pads checks the refcount, but there are timers inside the jitterbuffer that can push things, so if we're not lucky, things could be pushed while the pads are being shut down. Putting the jitterbuffer to NULL first avoids this. --- tests/check/elements/rtpjitterbuffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/check/elements/rtpjitterbuffer.c b/tests/check/elements/rtpjitterbuffer.c index 5c13a0c6a3..80da5b5d94 100644 --- a/tests/check/elements/rtpjitterbuffer.c +++ b/tests/check/elements/rtpjitterbuffer.c @@ -168,6 +168,7 @@ cleanup_jitterbuffer (GstElement * jitterbuffer) gst_pad_set_active (mysrcpad, FALSE); gst_pad_set_active (mysinkpad, FALSE); + gst_element_set_state (jitterbuffer, GST_STATE_NULL); gst_check_teardown_src_pad (jitterbuffer); gst_check_teardown_sink_pad (jitterbuffer); gst_check_teardown_element (jitterbuffer);