From c5ae18491086953f5dcf6a194a7a16f1548c0bf0 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Fri, 12 Dec 2008 19:41:28 +0000 Subject: [PATCH] gst-libs/gst/cdda/gstcddabasesrc.c: Remove erroneous gst_buffer_ref(). Original commit message from CVS: * gst-libs/gst/cdda/gstcddabasesrc.c: (gst_cdda_base_src_handle_event): Remove erroneous gst_buffer_ref(). * tests/check/libs/rtp.c: (GST_START_TEST): Don't forget to unref the buffer once you're done with it. --- ChangeLog | 8 ++++++++ common | 2 +- gst-libs/gst/cdda/gstcddabasesrc.c | 1 - tests/check/libs/rtp.c | 1 + 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index f342bbf487..4987850eac 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-12-12 Edward Hervey + + * gst-libs/gst/cdda/gstcddabasesrc.c: + (gst_cdda_base_src_handle_event): + Remove erroneous gst_buffer_ref(). + * tests/check/libs/rtp.c: (GST_START_TEST): + Don't forget to unref the buffer once you're done with it. + 2008-12-12 Stefan Kost * gst/playback/gstplaybin.c: diff --git a/common b/common index f811de62e9..1c24dce4e3 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit f811de62e9cea6e3d4174a0b172733b2c7952c1d +Subproject commit 1c24dce4e32f0a725ebd1b8ba2cd48d373818f75 diff --git a/gst-libs/gst/cdda/gstcddabasesrc.c b/gst-libs/gst/cdda/gstcddabasesrc.c index 6e2999b0ea..910d83e525 100644 --- a/gst-libs/gst/cdda/gstcddabasesrc.c +++ b/gst-libs/gst/cdda/gstcddabasesrc.c @@ -877,7 +877,6 @@ gst_cdda_base_src_handle_event (GstBaseSrc * basesrc, GstEvent * event) } default:{ GST_LOG_OBJECT (src, "let base class handle event"); - event = gst_event_ref (event); ret = GST_BASE_SRC_CLASS (parent_class)->event (basesrc, event); break; } diff --git a/tests/check/libs/rtp.c b/tests/check/libs/rtp.c index 346180086b..bfc33ae495 100644 --- a/tests/check/libs/rtp.c +++ b/tests/check/libs/rtp.c @@ -355,6 +355,7 @@ GST_START_TEST (test_rtcp_buffer) /* close and validate */ gst_rtcp_buffer_end (buf); fail_unless (gst_rtcp_buffer_validate (buf) == TRUE); + gst_buffer_unref (buf); } GST_END_TEST;