visual: use unused value
ret is assigned but not used and in the next cycle of the loop it is overwritten with default_prepare_output_buffer (). If there is a flow error the function should return instead. CID #1226475
This commit is contained in:
parent
881e51fffb
commit
b7fab0736d
@ -1179,6 +1179,8 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent,
|
|||||||
if (klass->render) {
|
if (klass->render) {
|
||||||
if (!klass->render (scope, inbuf, &outframe)) {
|
if (!klass->render (scope, inbuf, &outframe)) {
|
||||||
ret = GST_FLOW_ERROR;
|
ret = GST_FLOW_ERROR;
|
||||||
|
gst_video_frame_unmap (&outframe);
|
||||||
|
goto beach;
|
||||||
} else {
|
} else {
|
||||||
/* run various post processing (shading and geometric transformation) */
|
/* run various post processing (shading and geometric transformation) */
|
||||||
/* FIXME: SHADER assumes 32bpp */
|
/* FIXME: SHADER assumes 32bpp */
|
||||||
|
Loading…
x
Reference in New Issue
Block a user