From b7951fb897af6a06e8e102e5e8e7f4933205dcba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 8 Jun 2021 11:38:11 +0300 Subject: [PATCH] webrtcbin: Fix a couple of caps leaks of the offer caps Part-of: --- ext/webrtc/gstwebrtcbin.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c index beadefd812..e0e8d305fb 100644 --- a/ext/webrtc/gstwebrtcbin.c +++ b/ext/webrtc/gstwebrtcbin.c @@ -3718,6 +3718,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options, if (rtp_trans) gst_object_unref (rtp_trans); gst_caps_unref (answer_caps); + gst_caps_unref (offer_caps); goto rejected; } @@ -3732,6 +3733,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options, } else { trans = WEBRTC_TRANSCEIVER (rtp_trans); } + if (!_update_transceiver_kind_from_caps (rtp_trans, answer_caps)) GST_WARNING_OBJECT (webrtc, "Trying to change transceiver %d kind from %d to %d", @@ -3774,6 +3776,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options, if (answer_dir == GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_NONE) { GST_WARNING_OBJECT (webrtc, "Could not intersect offer direction with " "transceiver direction"); + gst_caps_unref (offer_caps); goto rejected; } _media_replace_direction (media, answer_dir);