From b78c119a420278c797d69b4a3da9ec63f219081f Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Sun, 5 Jan 2025 11:46:21 +0100 Subject: [PATCH] msemediabuffer: Fix ASCII character detection Use glib function. The previous check was checking whether a signed int was lower than its limit (which ... is always TRUE). Part-of: --- .../gst-libs/gst/mse/gstmsemediatype.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/mse/gstmsemediatype.c b/subprojects/gst-plugins-bad/gst-libs/gst/mse/gstmsemediatype.c index 85c19fa7ab..b80f2b0618 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/mse/gstmsemediatype.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/mse/gstmsemediatype.c @@ -56,12 +56,6 @@ is_token_character (const gchar c) return g_ascii_isgraph (c); } -static gboolean -is_ascii (const gchar c) -{ - return c > 0 && c <= G_MAXINT8; -} - static gboolean is_eos (const gchar c) { @@ -135,8 +129,8 @@ quoted_string_char (const gchar ** input, gchar * value) g_return_val_if_fail (value != NULL, FALSE); const gchar *unparsed = *input; - char c = unparsed[0]; - if (!is_ascii (c)) { + gchar c = unparsed[0]; + if (!g_ascii_isprint (c)) { return FALSE; } @@ -160,7 +154,7 @@ escaped_ascii_char (const gchar ** input, gchar * value) } gchar c = (*input)[0]; - if (!is_ascii (c)) { + if (!g_ascii_isprint (c)) { return FALSE; }