From b3cbdb1d26714cf0b89edfa4d67d5c70ccb8fdb2 Mon Sep 17 00:00:00 2001
From: Matthew Waters <matthew@centricular.com>
Date: Fri, 15 May 2020 13:52:06 +1000
Subject: [PATCH] amcvideodec: fix sync meta copying not taking a reference

Fixup for
9b9e39be248389370e80b429da5a528418733483: amc: Fix crash when a sync_meta survives its sink
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/603

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1272>
---
 sys/androidmedia/gstamcvideodec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/androidmedia/gstamcvideodec.c b/sys/androidmedia/gstamcvideodec.c
index 923c155702..73c7c2b1b6 100644
--- a/sys/androidmedia/gstamcvideodec.c
+++ b/sys/androidmedia/gstamcvideodec.c
@@ -1239,7 +1239,7 @@ _amc_gl_copy (GstGLSyncMeta * src, GstBuffer * sbuffer, GstGLSyncMeta * dest,
   g_mutex_lock (&sync->sink->gl_lock);
 
   tmp->refcount = 1;
-  tmp->sink = sync->sink;
+  tmp->sink = gst_object_ref (sync->sink);
   tmp->buffer = dbuffer;
   tmp->oes_mem = (GstGLMemory *) gst_memory_ref ((GstMemory *) sync->oes_mem);
   tmp->surface = g_object_ref (sync->surface);