FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

pluginloader: fix pending_plugins Glist use-after-free issue

Browse Source 
When plugin_loader_load_and_sync returns false in plugin_loader_replay_pending,
the cur Glist l->pending_plugins will be added to the blacklist.
However, the l->pending_plugins might have already been loaded and freed in handle_rx_packet,
so causing a use-after-free issue.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8747>
This commit is contained in:
Shengqi Yu (喻盛琪) 2025-04-01 11:02:58 +08:00 committed by GStreamer Marge Bot
parent 80a23d7132
commit b144375974
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
subprojects/gstreamer/gst/gstpluginloader.c
View File

@ -264,7 +264,12 @@ restart:
while ((cur = l->pending_plugins)) { while ((cur = l->pending_plugins)) {
PendingPluginEntry *entry = (PendingPluginEntry *) (cur->data); PendingPluginEntry *entry = (PendingPluginEntry *) (cur->data);
if (!plugin_loader_load_and_sync (l, entry)) { /* Maybe the cur(current head of the pending plugins list) has already been
* processed and deleted from pending plugins in handle_rx_packet when
* received this plugin details, so here add cur == l->pending_plugins
* to ensure that the cur is valid */
if (!plugin_loader_load_and_sync (l, entry)
&& cur == l->pending_plugins) {
/* Create dummy plugin entry to block re-scanning this file */ /* Create dummy plugin entry to block re-scanning this file */
GST_ERROR ("Plugin file %s failed to load. Blacklisting", GST_ERROR ("Plugin file %s failed to load. Blacklisting",
entry->filename); entry->filename);