From b09b246fc83a665ea3a3e89ec08111b36372a457 Mon Sep 17 00:00:00 2001 From: Elliot Chen Date: Thu, 10 Nov 2022 14:39:12 +0800 Subject: [PATCH] gstplay: add warning message details check before post it For some warning message which has no detail data, need check to avoid printing critical log. Part-of: --- .../gst-plugins-bad/gst-libs/gst/play/gstplay.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c index 40bd39c769..f99bbe1bcd 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c @@ -1061,9 +1061,15 @@ warning_cb (G_GNUC_UNUSED GstBus * bus, GstMessage * msg, gpointer user_data) GST_WARNING_OBJECT (self, "Warning: %s (%s, %d)", err->message, g_quark_to_string (err->domain), err->code); - api_bus_post_message (self, GST_PLAY_MESSAGE_WARNING, - GST_PLAY_MESSAGE_DATA_WARNING, G_TYPE_ERROR, play_err, - GST_PLAY_MESSAGE_DATA_WARNING_DETAILS, GST_TYPE_STRUCTURE, details, NULL); + if (details != NULL) { + api_bus_post_message (self, GST_PLAY_MESSAGE_WARNING, + GST_PLAY_MESSAGE_DATA_WARNING, G_TYPE_ERROR, play_err, + GST_PLAY_MESSAGE_DATA_WARNING_DETAILS, GST_TYPE_STRUCTURE, details, + NULL); + } else { + api_bus_post_message (self, GST_PLAY_MESSAGE_WARNING, + GST_PLAY_MESSAGE_DATA_WARNING, G_TYPE_ERROR, play_err, NULL); + } g_clear_error (&play_err); g_clear_error (&err);