FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

validate: Fix various memory leaks

Browse Source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9118>
This commit is contained in:
Doug Nazar 2025-05-28 09:01:08 -04:00 committed by GStreamer Marge Bot
parent 2f5ecdc911
commit b0885d2fc3
5 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
subprojects/gst-devtools/validate/gst/validate/flow/formatting.c
View File

@ -367,6 +367,7 @@ validate_flow_format_buffer (GstBuffer * buffer, gint checksum_type,
g_string_append_c (content, ' ');
g_string_append_printf (content, "0x%02x", map.data[i]);
}
gst_buffer_unmap (buffer, &map);
buffer_parts[buffer_parts_index++] = g_string_free (content, FALSE);
} else {
@ -436,6 +437,7 @@ validate_flow_format_buffer (GstBuffer * buffer, gint checksum_type,
buffer_parts_index > 0 ? g_strjoinv (", ",
buffer_parts) : g_strdup ("(empty)");
g_strfreev (logged_fields);
g_strfreev (ignored_fields);
g_free (meta_str);
g_free (flags_str);

5
subprojects/gst-devtools/validate/gst/validate/gst-validate-report.c
View File

@ -133,9 +133,8 @@ gst_validate_issue_unref (GstValidateIssue * issue)
if (G_UNLIKELY (g_atomic_int_dec_and_test (&issue->refcount))) {
g_free (issue->summary);
g_free (issue->description);
/* We are using an string array for area and name */
g_strfreev (&issue->area);
g_free (issue->area);
g_free (issue->name);
g_free (issue);
}

29
subprojects/gst-devtools/validate/gst/validate/gst-validate-scenario.c
View File

@ -758,6 +758,8 @@ _update_well_known_vars (GstValidateScenario * scenario)
} else {
GST_INFO_OBJECT (scenario, "Could not query position");
}
gst_object_unref (pipeline);
}
static GstElement *_get_target_element (GstValidateScenario * scenario,
@ -1391,6 +1393,7 @@ _set_timed_value (const GstIdStr * fieldname, const GValue * gvalue,
gst_object_add_control_binding (obj, binding);
} else {
g_object_get (binding, "control-source", &source, NULL);
gst_clear_object (&binding);
}
REPORT_UNLESS (GST_IS_TIMED_VALUE_CONTROL_SOURCE (source), err,
@ -1401,12 +1404,14 @@ _set_timed_value (const GstIdStr * fieldname, const GValue * gvalue,
GST_TIME_ARGS (timestamp));
gst_object_unref (obj);
gst_clear_object (&source);
gst_structure_set (structure, "__res__", G_TYPE_INT, res, NULL);
return TRUE;
err:
gst_clear_object (&obj);
gst_clear_object (&source);
gst_structure_set (structure, "__res__", G_TYPE_INT,
GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED, NULL);
@ -2224,6 +2229,7 @@ stream_selection_cb (GstBus * bus, GstMessage * message, SelectStreamData * d)
GstValidateScenario *scenario = NULL;
GstStreamCollection *collection = NULL, *selected_streams = NULL;
GList *streams = NULL;
GstElement *pipeline = NULL;
switch (GST_MESSAGE_TYPE (message)) {
case GST_MESSAGE_STREAM_COLLECTION:
@ -2289,7 +2295,7 @@ stream_selection_cb (GstBus * bus, GstMessage * message, SelectStreamData * d)
}
GstElement *pipeline = gst_validate_scenario_get_pipeline (scenario);
pipeline = gst_validate_scenario_get_pipeline (scenario);
if (pipeline == NULL) {
GST_VALIDATE_REPORT_ACTION (scenario, d->action,
SCENARIO_ACTION_EXECUTION_ERROR,
@ -2327,6 +2333,7 @@ done:
gst_clear_object (&scenario);
gst_clear_object (&collection);
gst_clear_object (&pipeline);
g_rec_mutex_unlock (&d->m);
}
@ -2363,6 +2370,9 @@ stream_selection_scenario_stopping_cb (GstValidateScenario * scenario,
d->stopping_sid = 0;
}
g_rec_mutex_unlock (&d->m);
gst_clear_object (&pipeline);
gst_clear_object (&bus);
}
static GstValidateExecuteActionReturn
@ -3647,6 +3657,7 @@ _execute_wait_for_sub_pipeline (GstValidateScenario * scenario,
(GClosureNotify) gst_validate_action_unref, G_CONNECT_AFTER);
gst_clear_object (&bus);
gst_clear_object (&pipeline);
return GST_VALIDATE_EXECUTE_ACTION_ASYNC;
}
@ -4222,6 +4233,7 @@ chain_wrapper_function_free (ChainWrapperFunctionData * data)
{
g_list_free_full (data->actions, (GDestroyNotify) gst_validate_action_unref);
g_mutex_clear (&data->actions_lock);
g_free (data);
}
static GstFlowReturn
@ -4230,8 +4242,7 @@ _pad_chain_wrapper (GstPad * pad, GstObject * parent, GstBuffer * buffer)
ChainWrapperFunctionData *data =
g_object_get_qdata (G_OBJECT (pad), chain_qdata);
return data->wrapper_function (pad, parent, buffer,
g_object_get_qdata (G_OBJECT (pad), chain_qdata));
return data->wrapper_function (pad, parent, buffer, data);
}
static void
@ -6240,6 +6251,7 @@ gst_validate_scenario_new (GstValidateRunner *
gst_validate_printf (NULL,
"**-> Using clock %" GST_PTR_FORMAT " on %" GST_PTR_FORMAT "**\n",
system_clock, pipeline);
gst_object_unref (system_clock);
}
gst_validate_reporter_set_name (GST_VALIDATE_REPORTER (scenario),
@ -7323,6 +7335,7 @@ typedef struct
{
GstValidateMonitor *monitor;
GstValidateAction *action;
GstElement *pipeline;
} SubPipelineData;
static void
@ -7330,7 +7343,8 @@ sub_pipeline_data_free (gpointer data)
{
SubPipelineData *sub_data = (SubPipelineData *) data;
g_clear_object (&sub_data->monitor);
gst_clear_object (&sub_data->monitor);
gst_clear_object (&sub_data->pipeline);
gst_validate_action_unref (sub_data->action);
}
@ -7344,10 +7358,6 @@ static void
subscenario_done_cb (GstBus * bus, GstMessage * message, gpointer data)
{
SubPipelineData *sub_data = (SubPipelineData *) data;
GstElement *pipeline =
GST_ELEMENT (gst_validate_monitor_get_target (sub_data->monitor));
g_assert (pipeline);
GstState state;
gst_message_parse_request_state (message, &state);
@ -7357,7 +7367,7 @@ subscenario_done_cb (GstBus * bus, GstMessage * message, gpointer data)
return;
}
gst_element_set_state (pipeline, GST_STATE_NULL);
gst_element_set_state (sub_data->pipeline, GST_STATE_NULL);
gst_validate_action_set_done (sub_data->action);
g_signal_handlers_disconnect_by_func (bus, subscenario_done_cb, data);
@ -7404,6 +7414,7 @@ _create_sub_pipeline (GstValidateScenario * scenario,
scenario_name ? scenario_name : (name ? name : "unnamed-subscenario"),
scenario_structures, TRUE));
data->action = gst_validate_action_ref (action);
data->pipeline = GST_ELEMENT_CAST (pipeline);
gboolean monitor_handles_state;
g_object_get (data->monitor, "handles-states", &monitor_handles_state, NULL);

2
subprojects/gst-devtools/validate/plugins/ssim/gstvalidatessim.c
View File

@ -326,7 +326,7 @@ _can_attach (GstValidateOverride * override, GstValidateMonitor * monitor)
GST_INFO_OBJECT (pad,
"Doesn't have template, can't use it %" GST_PTR_FORMAT,
gst_pad_query_caps (pad, NULL));
return FALSE;
goto fail;
}
template_caps = GST_PAD_TEMPLATE_CAPS (GST_PAD_PAD_TEMPLATE (pad));

2
subprojects/gst-devtools/validate/tools/gst-validate-transcoding.c
View File

@ -112,6 +112,8 @@ _execute_set_restriction (GstValidateScenario * scenario,
GstEncodingProfile *encoding_profile;
g_object_get (pipeline, "profile", &encoding_profile, NULL);
gst_object_unref (pipeline);
restriction_caps =
gst_structure_get_string (action->structure, "restriction-caps");
profile_type_name =