FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

faceblur: fix handling of profile property.

Browse Source 
Dup and free the string. Fixes leaking new values and avoids crashing
gst-inspect.
This commit is contained in:
Stefan Kost 2010-02-19 22:50:18 +02:00 committed by Thiago Santos
parent f35f701996
commit af83f0afd7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ext/opencv/faceblur/gstfaceblur.c
View File

@ -119,6 +119,8 @@ gst_faceblur_finalize (GObject * obj)
cvReleaseImage (&filter->cvGray); cvReleaseImage (&filter->cvGray);
} }
g_free (filter->profile);
G_OBJECT_CLASS (parent_class)->finalize (obj); G_OBJECT_CLASS (parent_class)->finalize (obj);
} }
@ -184,7 +186,7 @@ gst_faceblur_init (Gstfaceblur * filter, GstfaceblurClass * gclass)
gst_element_add_pad (GST_ELEMENT (filter), filter->sinkpad); gst_element_add_pad (GST_ELEMENT (filter), filter->sinkpad);
gst_element_add_pad (GST_ELEMENT (filter), filter->srcpad); gst_element_add_pad (GST_ELEMENT (filter), filter->srcpad);
filter->profile = DEFAULT_PROFILE; filter->profile = g_strdup (DEFAULT_PROFILE);
gst_faceblur_load_profile (filter); gst_faceblur_load_profile (filter);
} }
@ -196,6 +198,7 @@ gst_faceblur_set_property (GObject * object, guint prop_id,
switch (prop_id) { switch (prop_id) {
case PROP_PROFILE: case PROP_PROFILE:
g_free (filter->profile);
filter->profile = g_value_dup_string (value); filter->profile = g_value_dup_string (value);
gst_faceblur_load_profile (filter); gst_faceblur_load_profile (filter);
break; break;
@ -213,7 +216,7 @@ gst_faceblur_get_property (GObject * object, guint prop_id,
switch (prop_id) { switch (prop_id) {
case PROP_PROFILE: case PROP_PROFILE:
g_value_take_string (value, filter->profile); g_value_set_string (value, filter->profile);
break; break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);