FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

gloverlaycompositor: Don't leak caps feature

Browse Source 
Only copy it if we really are going to modify and use it

CID #1439873

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/652>
This commit is contained in:
Edward Hervey 2020-05-05 17:17:57 +02:00 committed by Edward Hervey
parent 637bbac622
commit add3023f09
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ext/gl/gstgloverlaycompositorelement.c
View File

@ -156,18 +156,15 @@ _oce_transform_internal_caps (GstGLFilter * filter,
for (i = 0; i < n; i++) { for (i = 0; i < n; i++) {
GstCapsFeatures *feat = gst_caps_get_features (removed, i); GstCapsFeatures *feat = gst_caps_get_features (removed, i);
if (feat) { if (feat && gst_caps_features_contains (feat,
feat = gst_caps_features_copy (feat);
if (gst_caps_features_contains (feat,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION)) { GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION)) {
feat = gst_caps_features_copy (feat);
/* prefer the passthrough case */ /* prefer the passthrough case */
gst_caps_features_remove (feat, gst_caps_features_remove (feat,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION); GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION);
gst_caps_set_features (removed, i, feat); gst_caps_set_features (removed, i, feat);
} }
} }
}
ret = gst_caps_merge (ret, removed); ret = gst_caps_merge (ret, removed);
} }