From acc9529a36ab7eef38539cce9ab7d11658df1fd4 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Sun, 18 Jan 2015 11:07:43 -0500 Subject: [PATCH] x264enc: Don't set an allocation maximum There is no reason x264enc should enforce a maximum allocation size. The maximum is normally set by buffer pool which cannot grow, but we don't offer a buffer pool. This would lead to stall when used with element that don't implement allocation query. Related to: https://bugzilla.gnome.org/show_bug.cgi?id=738302 --- ext/x264/gstx264enc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c index a5a1e41fa4..dd37c702ce 100644 --- a/ext/x264/gstx264enc.c +++ b/ext/x264/gstx264enc.c @@ -1932,8 +1932,7 @@ gst_x264_enc_propose_allocation (GstVideoEncoder * encoder, GstQuery * query) info = &self->input_state->info; num_buffers = x264_encoder_maximum_delayed_frames (self->x264enc) + 1; - gst_query_add_allocation_pool (query, NULL, info->size, num_buffers, - num_buffers); + gst_query_add_allocation_pool (query, NULL, info->size, num_buffers, 0); return GST_VIDEO_ENCODER_CLASS (parent_class)->propose_allocation (encoder, query);