From acb913a8784e65aa0a8d5fa9f99f9c97135c3c63 Mon Sep 17 00:00:00 2001 From: badcel <33569-badcel@users.noreply.gitlab.gnome.org> Date: Tue, 11 Apr 2023 21:23:00 +0200 Subject: [PATCH] base: adapter: Explicitly mark size parameter as input The generated gir file marks the size parameter as "out" by default. This is wrong in the context of a caller allocated buffer with a given size. Explicitly marking the size parameter as (in) fixes the issue. Part-of: --- subprojects/gstreamer/libs/gst/base/gstadapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gstreamer/libs/gst/base/gstadapter.c b/subprojects/gstreamer/libs/gst/base/gstadapter.c index 89f2e7160f..12d7569842 100644 --- a/subprojects/gstreamer/libs/gst/base/gstadapter.c +++ b/subprojects/gstreamer/libs/gst/base/gstadapter.c @@ -581,7 +581,7 @@ gst_adapter_unmap (GstAdapter * adapter) * @dest: (out caller-allocates) (array length=size) (element-type guint8): * the memory to copy into * @offset: the bytes offset in the adapter to start from - * @size: the number of bytes to copy + * @size: (in): the number of bytes to copy * * Copies @size bytes of data starting at @offset out of the buffers * contained in #GstAdapter into an array @dest provided by the caller.