From ab70aa60e27874e70155ff43261cf55c504b8d9e Mon Sep 17 00:00:00 2001
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: Tue, 30 Jul 2024 16:18:56 -0400
Subject: [PATCH] xvimagesink: Fix crash in pool on error

The set_config() virtual function is not support to free the config. As a side
effect, when there is protocol error of some sort, we endup with a crash.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7285>
---
 subprojects/gst-plugins-base/sys/xvimage/xvimagepool.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/subprojects/gst-plugins-base/sys/xvimage/xvimagepool.c b/subprojects/gst-plugins-base/sys/xvimage/xvimagepool.c
index 6e9a57d630..e1ee903f89 100644
--- a/subprojects/gst-plugins-base/sys/xvimage/xvimagepool.c
+++ b/subprojects/gst-plugins-base/sys/xvimage/xvimagepool.c
@@ -138,7 +138,6 @@ xvimage_buffer_pool_set_config (GstBufferPool * pool, GstStructure * config)
 
   if (!xvpool->pre_alloc_mem) {
     GST_ERROR_OBJECT (pool, "couldn't allocate image");
-    gst_structure_free (config);
     return FALSE;
   } else {
     gint i;