FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rtspconnection: make sure not to dereference NULL username or password

Browse Source 
Fixes #610268.
This commit is contained in:
Patrick Radizi 2010-02-18 12:42:53 +00:00 committed by Tim-Philipp Müller
parent 5685e0a4b7
commit a8f51d61f7
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gst-libs/gst/rtsp/gstrtspconnection.c
View File

@ -946,6 +946,9 @@ add_auth_header (GstRTSPConnection * conn, GstRTSPMessage * message)
gchar *user_pass64; gchar *user_pass64;
gchar *auth_string; gchar *auth_string;
if (conn->username == NULL || conn->passwd == NULL)
break;
user_pass = g_strdup_printf ("%s:%s", conn->username, conn->passwd); user_pass = g_strdup_printf ("%s:%s", conn->username, conn->passwd);
user_pass64 = g_base64_encode ((guchar *) user_pass, strlen (user_pass)); user_pass64 = g_base64_encode ((guchar *) user_pass, strlen (user_pass));
auth_string = g_strdup_printf ("Basic %s", user_pass64); auth_string = g_strdup_printf ("Basic %s", user_pass64);
@ -967,7 +970,8 @@ add_auth_header (GstRTSPConnection * conn, GstRTSPMessage * message)
const gchar *method; const gchar *method;
/* we need to have some params set */ /* we need to have some params set */
if (conn->auth_params == NULL) if (conn->auth_params == NULL || conn->username == NULL ||
conn->passwd == NULL)
break; break;
/* we need the realm and nonce */ /* we need the realm and nonce */