From a5e540bf55dafdfd25192745ccba6066db9f44fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Mon, 6 Mar 2017 00:30:41 +0000 Subject: [PATCH] voaacenc: limit bitrate property to 320 kbps This appears to be the internal limit of voaacenc, higher bitrates will be ignored and 128 kbps output will be produced instead. Therefore, we might just as well limit the allowed property values, so that people who try to set higher bitrates get a big fat warning instead of silently a much lower bitrate. --- ext/voaacenc/gstvoaacenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/voaacenc/gstvoaacenc.c b/ext/voaacenc/gstvoaacenc.c index 674c4815b3..9c48ea2051 100644 --- a/ext/voaacenc/gstvoaacenc.c +++ b/ext/voaacenc/gstvoaacenc.c @@ -159,8 +159,8 @@ gst_voaacenc_class_init (GstVoAacEncClass * klass) g_object_class_install_property (object_class, PROP_BITRATE, g_param_spec_int ("bitrate", "Bitrate", - "Target Audio Bitrate", - 0, G_MAXINT, VOAAC_ENC_DEFAULT_BITRATE, + "Target Audio Bitrate (bits per second)", + 0, 320000, VOAAC_ENC_DEFAULT_BITRATE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); gst_element_class_add_static_pad_template (element_class, &sink_template);