FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Unref pads when iterating over them in analyse_source.

Browse Source 
Fixes leak of source's srcpad when using uridecodebin.
This commit is contained in:
Michael Smith 2009-01-30 10:38:17 -08:00
parent 125d7bda9b
commit a2b0229058
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gst/playback/gsturidecodebin.c
View File

@ -943,12 +943,15 @@ analyse_source (GstURIDecodeBin * decoder, gboolean * is_raw,
*have_out = TRUE; *have_out = TRUE;
/* if FALSE, this pad has no caps and we continue with the next pad. */ /* if FALSE, this pad has no caps and we continue with the next pad. */
if (!has_all_raw_caps (pad, is_raw)) if (!has_all_raw_caps (pad, is_raw)) {
gst_object_unref (pad);
break; break;
}
/* caps on source pad are all raw, we can add the pad */ /* caps on source pad are all raw, we can add the pad */
if (*is_raw) if (*is_raw)
new_decoded_pad_cb (decoder->source, pad, FALSE, decoder); new_decoded_pad_cb (decoder->source, pad, FALSE, decoder);
gst_object_unref (pad);
break; break;
} }
} }
@ -1569,6 +1572,7 @@ decoder_query_duration_fold (GstPad * item, GValue * ret, QueryFold * fold)
gst_object_unref (item); gst_object_unref (item);
return TRUE; return TRUE;
} }
static void static void
decoder_query_duration_done (GstURIDecodeBin * dec, QueryFold * fold) decoder_query_duration_done (GstURIDecodeBin * dec, QueryFold * fold)
{ {
@ -1600,6 +1604,7 @@ decoder_query_position_fold (GstPad * item, GValue * ret, QueryFold * fold)
gst_object_unref (item); gst_object_unref (item);
return TRUE; return TRUE;
} }
static void static void
decoder_query_position_done (GstURIDecodeBin * dec, QueryFold * fold) decoder_query_position_done (GstURIDecodeBin * dec, QueryFold * fold)
{ {
@ -1642,6 +1647,7 @@ decoder_query_latency_fold (GstPad * item, GValue * ret, QueryFold * fold)
gst_object_unref (item); gst_object_unref (item);
return TRUE; return TRUE;
} }
static void static void
decoder_query_latency_done (GstURIDecodeBin * dec, QueryFold * fold) decoder_query_latency_done (GstURIDecodeBin * dec, QueryFold * fold)
{ {
@ -1673,6 +1679,7 @@ decoder_query_seeking_fold (GstPad * item, GValue * ret, QueryFold * fold)
return TRUE; return TRUE;
} }
static void static void
decoder_query_seeking_done (GstURIDecodeBin * dec, QueryFold * fold) decoder_query_seeking_done (GstURIDecodeBin * dec, QueryFold * fold)
{ {