FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vabasedec: Always chain to parent class negotiate vmethod

Browse Source 
When the base videodecoder class re-attempts a negotiation after flush, the
vabasedec `need_negotiation` flag isn't necessarily set to TRUE, because in that
situation the input state hasn't changed.

By always chaining up we are sure that buffer pool negotiation will always be
attempted.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9457>
This commit is contained in:
Philippe Normand 2025-07-28 12:49:36 +01:00
parent 914beb9756
commit a28a040913
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
subprojects/gst-plugins-bad/sys/va/gstvabasedec.c
View File

@ -673,9 +673,12 @@ gst_va_base_dec_negotiate (GstVideoDecoder * decoder)
{
GstVaBaseDec *base = GST_VA_BASE_DEC (decoder);
/* Ignore downstream renegotiation request. */
if (!base->need_negotiation)
return TRUE;
/* Do not (re-)open the decoder in case the input state hasn't changed. */
if (!base->need_negotiation) {
GST_DEBUG_OBJECT (decoder,
"Input state hasn't changed, no need to (re-)open the decoder");
goto done;
}
base->need_negotiation = FALSE;
@ -694,6 +697,7 @@ gst_va_base_dec_negotiate (GstVideoDecoder * decoder)
if (!gst_va_base_dec_set_output_state (base))
return FALSE;
done:
return GST_VIDEO_DECODER_CLASS (GST_VA_BASE_DEC_GET_PARENT_CLASS (decoder))
->negotiate (decoder);
}