From 9f1887a62335b01a1aa21876fa2fdae9ab7a9a33 Mon Sep 17 00:00:00 2001 From: He Junyan Date: Wed, 26 Jun 2024 22:22:47 +0800 Subject: [PATCH] glupload: Add a comment in DMA's propose_allocation query for video meta The video meta API now is a mandatory request for DMA kind negotiation. In current code, the raw method always adds that video meta API in the query of propose_allocation(), so we do not need to do the duplicated task here. Just adding a comment to declare that. Part-of: --- subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c b/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c index bafd804fe8..f5cec60a68 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c @@ -1647,7 +1647,8 @@ static void _dma_buf_upload_propose_allocation (gpointer impl, GstQuery * decide_query, GstQuery * query) { - /* nothing to do for now. */ + /* The raw method always adds the GST_VIDEO_META_API_TYPE + and so nothing to do here. */ } static void