From 9c291904f58d9cf5f7a84a2adf2abef79fe04c12 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Sat, 1 Aug 2015 15:09:19 -0300 Subject: [PATCH] tests: dash_mpd: add one more baseURL test This other type of baseURL test was replaced by a more complex one, better have both to keep both options working Also adds another 2 variations of how baseURL can be generated https://bugzilla.gnome.org/show_bug.cgi?id=752776 --- tests/check/elements/dash_mpd.c | 152 ++++++++++++++++++++++++++++---- 1 file changed, 134 insertions(+), 18 deletions(-) diff --git a/tests/check/elements/dash_mpd.c b/tests/check/elements/dash_mpd.c index b7333dfc02..9e55eb3498 100644 --- a/tests/check/elements/dash_mpd.c +++ b/tests/check/elements/dash_mpd.c @@ -3005,30 +3005,16 @@ GST_START_TEST (dash_mpdparser_get_audio_languages) GST_END_TEST; /* - * Test getting the base URL + * Tests getting the base URL * */ -GST_START_TEST (dash_mpdparser_get_baseURL) +static GstMpdClient * +setup_mpd_client (const gchar * xml) { GList *adaptationSets; GstAdaptationSetNode *adapt_set; guint activeStreams; guint adaptationSetsCount; - const gchar *baseURL; - - const gchar *xml = - "" - "" - " mpd_base_url/" - " " - " /period_base_url/" - " " - " adaptation_base_url" - " " - " representation_base_url" - " "; - gboolean ret; GstMpdClient *mpdclient = gst_mpd_client_new (); @@ -3054,6 +3040,52 @@ GST_START_TEST (dash_mpdparser_get_baseURL) activeStreams = gst_mpdparser_get_nb_active_stream (mpdclient); assert_equals_int (activeStreams, adaptationSetsCount); + return mpdclient; +} + +GST_START_TEST (dash_mpdparser_get_baseURL1) +{ + const gchar *baseURL; + const gchar *xml = + "" + "" + " http://example.com/" + " " + " " + " " + " "; + + GstMpdClient *mpdclient = setup_mpd_client (xml); + + baseURL = gst_mpdparser_get_baseURL (mpdclient, 0); + fail_if (baseURL == NULL); + assert_equals_string (baseURL, "http://example.com/"); + + gst_mpd_client_free (mpdclient); +} + +GST_END_TEST; + + +GST_START_TEST (dash_mpdparser_get_baseURL2) +{ + const gchar *baseURL; + const gchar *xml = + "" + "" + " mpd_base_url/" + " " + " /period_base_url/" + " " + " adaptation_base_url" + " " + " representation_base_url" + " "; + + GstMpdClient *mpdclient = setup_mpd_client (xml); + /* test baseURL. Its value should be computed like this: * - start with xml url (null) * - set it to the value from MPD's BaseURL element: "mpd_base_url/" @@ -3077,6 +3109,87 @@ GST_START_TEST (dash_mpdparser_get_baseURL) GST_END_TEST; + +GST_START_TEST (dash_mpdparser_get_baseURL3) +{ + const gchar *baseURL; + const gchar *xml = + "" + "" + " mpd_base_url/" + " " + " /period_base_url/" + " " + " adaptation_base_url" + " " + " /representation_base_url" + " "; + + GstMpdClient *mpdclient = setup_mpd_client (xml); + + /* test baseURL. Its value should be computed like this: + * - start with xml url (null) + * - set it to the value from MPD's BaseURL element: "mpd_base_url/" + * - update the value with BaseURL element from Period. Because Period's + * baseURL is absolute (starts with /) it will overwrite the current value + * for baseURL. So, baseURL becomes "/period_base_url/" + * - update the value with BaseURL element from AdaptationSet. Because this + * is a relative url, it will update the current value. baseURL becomes + * "/period_base_url/adaptation_base_url" + * - update the value with BaseURL element from Representation. Because this + * is an absolute url, it will replace everything again" + */ + baseURL = gst_mpdparser_get_baseURL (mpdclient, 0); + fail_if (baseURL == NULL); + assert_equals_string (baseURL, "/representation_base_url"); + + gst_mpd_client_free (mpdclient); +} + +GST_END_TEST; + + +GST_START_TEST (dash_mpdparser_get_baseURL4) +{ + const gchar *baseURL; + const gchar *xml = + "" + "" + " mpd_base_url/" + " " + " /period_base_url/" + " " + " adaptation_base_url/" + " " + " representation_base_url/" + " "; + + GstMpdClient *mpdclient = setup_mpd_client (xml); + + /* test baseURL. Its value should be computed like this: + * - start with xml url (null) + * - set it to the value from MPD's BaseURL element: "mpd_base_url/" + * - update the value with BaseURL element from Period. Because Period's + * baseURL is absolute (starts with /) it will overwrite the current value + * for baseURL. So, baseURL becomes "/period_base_url/" + * - update the value with BaseURL element from AdaptationSet. Because this + * is a relative url, it will update the current value. baseURL becomes + * "/period_base_url/adaptation_base_url/" + * - update the value with BaseURL element from Representation. Because this + * is an relative url, it will update the current value." + */ + baseURL = gst_mpdparser_get_baseURL (mpdclient, 0); + fail_if (baseURL == NULL); + assert_equals_string (baseURL, + "/period_base_url/adaptation_base_url/representation_base_url/"); + + gst_mpd_client_free (mpdclient); +} + +GST_END_TEST; + /* * Test getting mediaPresentationDuration * @@ -4193,7 +4306,10 @@ dash_suite (void) tcase_add_test (tc_complexMPD, dash_mpdparser_activeStream_selection); tcase_add_test (tc_complexMPD, dash_mpdparser_activeStream_parameters); tcase_add_test (tc_complexMPD, dash_mpdparser_get_audio_languages); - tcase_add_test (tc_complexMPD, dash_mpdparser_get_baseURL); + tcase_add_test (tc_complexMPD, dash_mpdparser_get_baseURL1); + tcase_add_test (tc_complexMPD, dash_mpdparser_get_baseURL2); + tcase_add_test (tc_complexMPD, dash_mpdparser_get_baseURL3); + tcase_add_test (tc_complexMPD, dash_mpdparser_get_baseURL4); tcase_add_test (tc_complexMPD, dash_mpdparser_get_mediaPresentationDuration); tcase_add_test (tc_complexMPD, dash_mpdparser_get_streamPresentationOffset); tcase_add_test (tc_complexMPD, dash_mpdparser_segments);