FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

alsadeviceprovider: Fix leak of Alsa longname

Browse Source 
Detected by ASan.

As a drive-by fix, use free() instead of g_free() in gstalsadeviceprovider.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8619>
This commit is contained in:
Olivier Blin 2025-03-12 10:30:04 +01:00 committed by GStreamer Marge Bot
parent bd3aabbc25
commit 9b47a2dde3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
subprojects/gst-plugins-base/ext/alsa/gstalsadeviceprovider.c
View File

@ -56,7 +56,7 @@ add_device (GstDeviceProvider * provider, snd_ctl_t * info,
if (snd_pcm_open (&handle, device_name, stream, SND_PCM_NONBLOCK) < 0) {
GST_ERROR_OBJECT (provider, "Could not open device %s for inspection!",
device_name);
g_free (device_name);
free (device_name);
return NULL;
}
@ -72,7 +72,7 @@ add_device (GstDeviceProvider * provider, snd_ctl_t * info,
"device.class", G_TYPE_STRING, "sound",
"alsa.card", G_TYPE_INT, card,
"alsa.card_name", G_TYPE_STRING, card_name, NULL);
g_free (card_name);
free (card_name);
snd_ctl_card_info_alloca (&card_info);
if (snd_ctl_card_info (info, card_info) == 0) {
@ -89,6 +89,7 @@ add_device (GstDeviceProvider * provider, snd_ctl_t * info,
snd_card_get_longname (card, &longname);
device = gst_alsa_device_new (longname, caps, device_name, stream, props);
free (longname);
snd_pcm_close (handle);
@ -265,7 +266,7 @@ gst_alsa_device_finalize (GObject * object)
{
GstAlsaDevice *device = GST_ALSA_DEVICE (object);
g_free (device->internal_name);
free (device->internal_name);
G_OBJECT_CLASS (gst_alsa_device_parent_class)->finalize (object);
}