From 9a1ed36b7a73120309ea4cacfeba48dc939a0616 Mon Sep 17 00:00:00 2001 From: Vineeth TM Date: Mon, 22 Jun 2015 13:05:29 +0900 Subject: [PATCH] matroska: remove useless check No need to check for context availability while freeing. We are inside inside a code block with a condition that dereferences context. if (context->type == 0 ... https://bugzilla.gnome.org/show_bug.cgi?id=751306 --- gst/matroska/matroska-demux.c | 4 +--- gst/matroska/matroska-parse.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/gst/matroska/matroska-demux.c b/gst/matroska/matroska-demux.c index 756aa67efe..ad0670fa33 100644 --- a/gst/matroska/matroska-demux.c +++ b/gst/matroska/matroska-demux.c @@ -1123,9 +1123,7 @@ gst_matroska_demux_add_stream (GstMatroskaDemux * demux, GstEbmlRead * ebml) demux->common.num_streams--; g_ptr_array_remove_index (demux->common.src, demux->common.num_streams); g_assert (demux->common.src->len == demux->common.num_streams); - if (context) { - gst_matroska_track_free (context); - } + gst_matroska_track_free (context); return ret; } diff --git a/gst/matroska/matroska-parse.c b/gst/matroska/matroska-parse.c index 53b4eaca72..11de18b503 100644 --- a/gst/matroska/matroska-parse.c +++ b/gst/matroska/matroska-parse.c @@ -940,9 +940,7 @@ gst_matroska_parse_add_stream (GstMatroskaParse * parse, GstEbmlRead * ebml) parse->common.num_streams--; g_ptr_array_remove_index (parse->common.src, parse->common.num_streams); g_assert (parse->common.src->len == parse->common.num_streams); - if (context) { - gst_matroska_track_free (context); - } + gst_matroska_track_free (context); return ret; }